View Issue Details

IDProjectCategoryView StatusLast Update
0004877Talerotherpublic2017-06-06 12:18
ReporterFlorian Dold Assigned ToMarcello Stanisci Resolution deadline
ImplementerReviewer 
Release signed byDeployed by 
VerifierCommunicator 
Data protection authority notification requiredNo  
CSIRT notification requiredNo  
Estimated effort (hours)Actual effort (hours)0 
Fast-trackNo
Work packagenone
PriorityhighSeveritytextReproducibilityhave not tried
Status closedResolutionfixed 
Product Versiongit (master) 
Target Version0.3Fixed in Version0.3 
Summary0004877: migrate to new contract-related terminology
DescriptionIn the new terminology, the frontend creates an "order", the HTTP PUTs it to the backends /propopsal endpoint, which returns the proposal corresponding to the order (with the merchant signature and missing fields in the order filled out.

With a HTTP GET on /proposal, the frontend can query proposals by transaction ID or proposal hash.

The wallet stores as a "contract" the proposal together with signed coins.

Also, "transaction_id" becomes "order_id", since it's used by the frontend to uniquely identify an order.

The transaction_id name might be reused in the future for negotiating instances of payments for the *same* proposal between the exchange and merchant. It's not part of the contract anymore.
TagsNo tags attached.

Required notifications

Address or linkRemarkAdded byNotifiedActions

Relationships

related to 0004873 closedFlorian Dold Update contract fields 

Activities

Christian Grothoff

2017-03-02 07:00

manager   ~0011878

I thought this was already implemented. What's the status? (I fixed some related API docs today, sent you an e-mail about it).

Marcello Stanisci

2017-03-02 10:34

reporter   ~0011882

Yes and no. The source code is ported, but _comments_ don't match
ported code yet, at least in the merchant backend.

And as of API/docs, I'm pretty sure they're still mainly obsolete.

What to do with this issue?

Marcello Stanisci

2017-05-02 07:39

reporter   ~0012092

addressing remaining leftovers in merchant's and api's codebases.
There might be other parts in the whole Taler code having obsolete
names, but I think the current state is enough to close this never-ending bug.

Issue History

Date ModifiedUsernameFieldChange
2017-02-01 14:18Florian DoldNew Issue
2017-02-02 07:42Florian DoldDescription Updated
2017-02-26 02:06Christian GrothoffPrioritynormal => high
2017-02-26 02:06Christian GrothoffSeverityminor => text
2017-02-26 02:06Christian GrothoffStatusnew => implementing
2017-02-26 02:06Christian GrothoffProduct Version => git (master)
2017-03-02 07:00Christian GrothoffNote Added: 0011878
2017-03-02 07:01Christian GrothoffAssigned To => Marcello Stanisci
2017-03-02 07:01Christian GrothoffStatusimplementing => assigned
2017-03-02 07:01Christian GrothoffTarget Version => 0.3
2017-03-02 07:04Christian GrothoffRelationship addedrelated to 0004873
2017-03-02 10:34Marcello StanisciNote Added: 0011882
2017-05-02 07:39Marcello StanisciStatusassigned => informing
2017-05-02 07:39Marcello StanisciResolutionopen => fixed
2017-05-02 07:39Marcello StanisciNote Added: 0012092
2017-05-03 00:16Christian GrothoffFixed in Version => 0.3
2017-06-06 12:18Christian GrothoffStatusinforming => closed