View Issue Details

IDProjectCategoryView StatusLast Update
0004820Talerobsolete componentpublic2017-06-06 12:18
ReporterFlorian Dold Assigned ToFlorian Dold Resolution deadline
ImplementerReviewer 
Release signed byDeployed by 
VerifierCommunicator 
Data protection authority notification requiredNo  
CSIRT notification requiredNo  
Estimated effort (hours)Actual effort (hours)0 
Fast-trackNo
Work packagenone
PrioritynormalSeveritytweakReproducibilityhave not tried
Status closedResolutionfixed 
Product Versiongit (master) 
Target Version0.3Fixed in Version0.3 
Summary0004820: clean up and refactor bank code
DescriptionLooks like some cruft has accumulated in the bank, we should work towards making the code base cleaner/more readable.
TagsNo tags attached.

Required notifications

Address or linkRemarkAdded byNotifiedActions

Activities

Florian Dold

2016-11-28 10:19

manager   ~0011548

Last edited: 2016-11-28 10:28

Issues are:
- code organization is still kinda disorganized
- error handling is inconsistent
- we use tuples and generally not very nice APIs internally

Florian Dold

2016-11-28 10:20

manager   ~0011549

There also is a lot of dead code and code that can be simplified.

Marcello Stanisci

2016-12-05 21:01

reporter   ~0011568

FYI: none of the bank's branches can now work on my env.taler.net setup.

Florian Dold

2017-01-13 14:01

manager   ~0011632

Fixed these issues in commits af104fce9..632f19633

The bank's source code is now significantly smaller.

Issue History

Date ModifiedUsernameFieldChange
2016-11-28 10:14Florian DoldNew Issue
2016-11-28 10:14Florian DoldStatusnew => assigned
2016-11-28 10:14Florian DoldAssigned To => Marcello Stanisci
2016-11-28 10:19Florian DoldNote Added: 0011548
2016-11-28 10:19Florian DoldAssigned ToMarcello Stanisci => Florian Dold
2016-11-28 10:20Florian DoldNote Added: 0011549
2016-11-28 10:28Florian DoldNote Edited: 0011548
2016-11-28 12:21Christian GrothoffSeverityminor => tweak
2016-12-05 21:01Marcello StanisciNote Added: 0011568
2017-01-13 14:01Florian DoldStatusassigned => informing
2017-01-13 14:01Florian DoldResolutionopen => fixed
2017-01-13 14:01Florian DoldNote Added: 0011632
2017-01-16 09:21Christian GrothoffProduct Version => git (master)
2017-01-16 09:21Christian GrothoffFixed in Version => 0.3
2017-01-16 09:21Christian GrothoffTarget Version => 0.3
2017-06-06 12:18Christian GrothoffStatusinforming => closed
2022-08-23 18:26Christian GrothoffCategorybank (demonstrator) => py bank (demonstrator, obsolete)
2023-12-03 00:23Christian GrothoffCategorypy bank (demonstrator, obsolete) => obsolete componet
2023-12-11 19:08Florian DoldCategoryobsolete componet => obsolete component