View Issue Details

IDProjectCategoryView StatusLast Update
0004789Talerwallet (WebExtension)public2016-11-20 02:26
ReporterFlorian Dold Assigned ToFlorian Dold Resolution deadline
ImplementerReviewer 
Release signed byDeployed by 
VerifierCommunicator 
Data protection authority notification requiredNo  
CSIRT notification requiredNo  
Estimated effort (hours)Actual effort (hours)0 
Fast-trackNo
Work packagenone
PrioritynormalSeveritytextReproducibilityhave not tried
Status closedResolutionfixed 
Product Versiongit (master) 
Target Version0.2Fixed in Version0.2 
Summary0004789: i18n missing for JSX literals
DescriptionJSX literals like this

  <i18n.Translate>
    Hello <span>{userName}</span>!
  </i18n.Translate>

  <i18n.TranslateSwitch target={number}>
    <i18n.TranslateSingular>You have <span>number</span> apple!</i18n.TranslateSingular>
    <i18n.TranslatePlural>You have <span>{number}</span> apples!</i18n.TranslatePlural>
  </i18n.TranslateSwitch>

should be picked up by pogen.
TagsNo tags attached.

Required notifications

Address or linkRemarkAdded byNotifiedActions

Activities

Florian Dold

2016-11-17 01:10

manager   ~0011506

The extraction is now implemented.

The only thing that's missing is the integration with the Jed JS library to to the actual translation. This is kind of tricky, since with the JSX format, we get *either* the plural or the singular form, but by default Jed/gettext requires both for the lookup.

Florian Dold

2016-11-17 02:01

manager   ~0011507

Fixed in 4d7d1a1. The final syntax is updated in the description above.

Issue History

Date ModifiedUsernameFieldChange
2016-11-15 12:59Florian DoldNew Issue
2016-11-15 12:59Florian DoldStatusnew => assigned
2016-11-15 12:59Florian DoldAssigned To => Florian Dold
2016-11-15 14:38rootSeverityminor => text
2016-11-15 14:38rootProduct Version => git (master)
2016-11-15 14:38rootTarget Version => 0.2
2016-11-17 01:08Florian DoldDescription Updated
2016-11-17 01:10Florian DoldNote Added: 0011506
2016-11-17 02:01Florian DoldNote Added: 0011507
2016-11-17 02:01Florian DoldStatusassigned => informing
2016-11-17 02:01Florian DoldResolutionopen => fixed
2016-11-19 00:45Christian GrothoffFixed in Version => 0.2
2016-11-20 02:26Christian GrothoffStatusinforming => closed
2023-04-13 18:37Florian DoldCategorywallet (WebExtensions) => wallet (WebExtension)