View Issue Details

IDProjectCategoryView StatusLast Update
0004787Talerotherpublic2016-11-20 02:26
ReporterFlorian Dold Assigned ToMarcello Stanisci Resolution deadline
ImplementerReviewer 
Release signed byDeployed by 
VerifierCommunicator 
Data protection authority notification requiredNo  
CSIRT notification requiredNo  
Estimated effort (hours)Actual effort (hours)0 
Fast-trackNo
Work packagenone
PriorityhighSeveritytweakReproducibilityhave not tried
Status closedResolutionfixed 
Product Versiongit (master) 
Target Version0.2Fixed in Version0.2 
Summary0004787: Use 1e-8 instead of 1e-6 as the fractional unit of coins
DescriptionWe decided to to this because we can then represent Bitcoin's smallest currency unit.

Affects various components and configuration files.
TagsNo tags attached.

Required notifications

Address or linkRemarkAdded byNotifiedActions

Activities

Florian Dold

2016-11-17 02:04

manager   ~0011508

The preparations in the wallet are done, assigning to Marcello now for the bank, merchant frontends and configuration.

We ideally should have at most one constant in every repository that defines the fractional base. I believe that is not the case for e.g. the frontends (and maybe the bank).

Marcello Stanisci

2016-11-17 09:21

reporter   ~0011510

Why is that not the case for FEs and bank? Bank has its settings.py and
as of FEs we could define a dummy module hosting nothing but this constant
(IIUC your comment).

Marcello Stanisci

2016-11-17 09:23

reporter   ~0011511

Well, the problem could arise if we need this constant in JavaScript..

Marcello Stanisci

2016-11-19 11:53

reporter   ~0011534

Done for frontends (5783aeee9) and bank (0c673bea9a),
and deployment configs updated accordingly, as it's there
that they read that information.

Issue History

Date ModifiedUsernameFieldChange
2016-11-14 15:23Florian DoldNew Issue
2016-11-15 14:38rootAssigned To => Florian Dold
2016-11-15 14:38rootSeverityminor => tweak
2016-11-15 14:38rootStatusnew => assigned
2016-11-15 14:38rootProduct Version => git (master)
2016-11-15 14:38rootTarget Version => 0.2
2016-11-17 02:04Florian DoldNote Added: 0011508
2016-11-17 02:04Florian DoldAssigned ToFlorian Dold => Marcello Stanisci
2016-11-17 09:21Marcello StanisciNote Added: 0011510
2016-11-17 09:23Marcello StanisciNote Added: 0011511
2016-11-18 14:45Marcello StanisciPrioritynormal => high
2016-11-19 11:53Marcello StanisciNote Added: 0011534
2016-11-19 11:54Christian GrothoffStatusassigned => informing
2016-11-19 11:54Christian GrothoffResolutionopen => fixed
2016-11-19 11:54Christian GrothoffFixed in Version => 0.2
2016-11-20 02:26Christian GrothoffStatusinforming => closed