View Issue Details

IDProjectCategoryView StatusLast Update
0004759Talerexchangepublic2019-12-20 18:12
ReporterMarcello Stanisci Assigned ToMarcello Stanisci Resolution deadline
ImplementerReviewer 
Release signed byDeployed by 
VerifierCommunicator 
Data protection authority notification requiredNo  
CSIRT notification requiredNo  
Estimated effort (hours)Actual effort (hours)0 
Fast-trackNo
Work packagenone
PrioritynormalSeverityfeatureReproducibilityhave not tried
Status closedResolutionwon't fix 
Product Version0.1 
Target Version0.6Fixed in Version0.6 
Summary0004759: Fake errors needed
DescriptionBugs as 0004732 need errors to be correctly tested, so the exchange should
provide some way of generating errors. Moreover, some of them should not occur
always, as otherwise we can't test other stuff. I suggest a mix of config values
and URL parameters, like:

[exchange]
..
debug = "true";
..

and a URL like /track/transfer?wtid=x&error=yes. So if 'debug' is set, then the
exchange will return a conflict for wtid 'x'; if 'debug' is not set, then this is
just a malformed URL (so we keep production exchange safe).
TagsNo tags attached.

Required notifications

Address or linkRemarkAdded byNotifiedActions

Relationships

child of 0004454 closedMarcello Stanisci fault injection for all GNU Taler APIs 

Activities

Christian Grothoff

2016-11-03 16:59

manager   ~0011416

I agree with testing, but disagree with the proposed method. We should not complicate the exchange C code with such test logic, it will make it harder to read, audit and debug.

Instead, we should (eventually) have an HTTP reverse proxy that injects such faults as a "man in the middle" for testing.

Here, I would additionally suggest that if a test wants to tell the proxy to inject errors, it should be done via HTTP headers, not by changing the URL.

Marcello Stanisci

2018-03-27 09:49

reporter   ~0012900

We opted for a HTTP proxy and NOT to touch anything in the tested components.

Issue History

Date ModifiedUsernameFieldChange
2016-11-03 15:21Marcello StanisciNew Issue
2016-11-03 15:21Marcello StanisciStatusnew => assigned
2016-11-03 15:21Marcello StanisciAssigned To => Christian Grothoff
2016-11-03 16:59Christian GrothoffNote Added: 0011416
2016-11-03 16:59Christian GrothoffRelationship addedchild of 0004454
2016-11-03 17:00Christian GrothoffAssigned ToChristian Grothoff =>
2016-11-03 17:00Christian GrothoffPrioritylow => normal
2016-11-03 17:00Christian GrothoffSeverityminor => feature
2016-11-03 17:00Christian GrothoffStatusassigned => implementing
2016-11-03 17:00Christian GrothoffProduct Version => 0.1
2016-11-03 17:00Christian GrothoffTarget Version => 0.6
2018-03-27 09:49Marcello StanisciAssigned To => Marcello Stanisci
2018-03-27 09:49Marcello StanisciStatusimplementing => closed
2018-03-27 09:49Marcello StanisciResolutionopen => won't fix
2018-03-27 09:49Marcello StanisciNote Added: 0012900
2018-04-15 18:37Christian GrothoffStatusclosed => informing
2018-04-15 18:37Christian GrothoffFixed in Version => 0.6
2019-12-20 18:12Christian GrothoffStatusinforming => closed