View Issue Details

IDProjectCategoryView StatusLast Update
0004750Talerwallet (WebExtension)public2016-11-20 02:26
ReporterMarcello Stanisci Assigned ToFlorian Dold Resolution deadline
ImplementerReviewer 
Release signed byDeployed by 
VerifierCommunicator 
Data protection authority notification requiredNo  
CSIRT notification requiredNo  
Estimated effort (hours)Actual effort (hours)0 
Fast-trackNo
Work packagenone
PrioritynormalSeverityblockReproducibilityhave not tried
Status closedResolutionfixed 
Product Version0.1 
Target Version0.2Fixed in Version0.2 
Summary0004750: New names for contract's fields
DescriptionChanges in contract specs:

1. "expiry" changed to "pay_deadline"
2. "receiver" changed to "instance"

The wallet should accept the new names.
TagsNo tags attached.

Required notifications

Address or linkRemarkAdded byNotifiedActions

Relationships

child of 0004749 closedMarcello Stanisci receiver -> instance 

Activities

Marcello Stanisci

2016-10-24 15:30

reporter   ~0011385

Setting as 'block' because it's blocking 0004749 from being tested.
Just that, it's not blocking any work though.

Florian Dold

2016-11-03 00:55

manager   ~0011404

Why is the instance in the root of the contract? It should be in the merchant data.

'contract.instance' should refer to a *contract* instance (which is a concept we don't have).

'contract.merchant.instance' would be much clearer!

Marcello Stanisci

2016-11-03 13:43

reporter   ~0011411

The idea was that "merchant" field would contain non-virtual informations (like real name, real address, etc.), but yes, it's clearer like this. Fixed in f1529a..2646afb.

Florian Dold

2016-11-03 18:57

manager   ~0011419

Now fixed in the wallet in 358c0ce

Issue History

Date ModifiedUsernameFieldChange
2016-10-22 17:26Marcello StanisciNew Issue
2016-10-22 17:26Marcello StanisciStatusnew => assigned
2016-10-22 17:26Marcello StanisciAssigned To => Florian Dold
2016-10-24 15:28Marcello StanisciRelationship addedchild of 0004749
2016-10-24 15:29Marcello StanisciSeverityminor => block
2016-10-24 15:30Marcello StanisciNote Added: 0011385
2016-10-25 08:24Christian GrothoffProduct Version => 0.1
2016-10-25 08:24Christian GrothoffTarget Version => 0.2
2016-11-03 00:55Florian DoldNote Added: 0011404
2016-11-03 00:55Florian DoldStatusassigned => feedback
2016-11-03 13:43Marcello StanisciNote Added: 0011411
2016-11-03 13:43Marcello StanisciStatusfeedback => assigned
2016-11-03 18:57Florian DoldNote Added: 0011419
2016-11-03 18:57Florian DoldStatusassigned => informing
2016-11-03 18:57Florian DoldResolutionopen => fixed
2016-11-15 15:03Christian GrothoffFixed in Version => 0.2
2016-11-20 02:26Christian GrothoffStatusinforming => closed
2023-04-13 18:37Florian DoldCategorywallet (WebExtensions) => wallet (WebExtension)