View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0004567 | Taler | deployment and operations | public | 2016-06-07 17:27 | 2016-10-11 15:28 |
| Reporter | Florian Dold | Assigned To | Marcello Stanisci | Resolution deadline | |
| Implementer | Reviewer | ||||
| Release signed by | Deployed by | ||||
| Verifier | Communicator | ||||
| Data protection authority notification required | No | ||||
| CSIRT notification required | No | ||||
| Estimated effort (hours) | Actual effort (hours) | 0 | |||
| Fast-track | No | ||||
| Work package | none | ||||
| Priority | normal | Severity | minor | Reproducibility | have not tried |
| Status | closed | Resolution | fixed | ||
| Product Version | 0.0 | ||||
| Target Version | 0.1 | Fixed in Version | 0.1 | ||
| Summary | 0004567: fix style and semantics issues in taler-build/switch_active.sh script | ||||
| Description | There's a host of issues: - Please use $(...) instead of backticks, backticks aren't nestable and less readable. - PLEASE check return codes. Currently we're switching to the deployment even though the build failed. - Use "set -xu". This detects undefined variables and exits when a command failed, which also would resolve the previous bullet point. - Indent code consistently. "if CONDITION; then" should be on one line. - Please also include some output (whether we switched or not), so that we can see in buildbot what was actually going on. | ||||
| Tags | No tags attached. | ||||
| I'll go for using "set -xu", but the script did check before switching, by the following lines: # check exit code if [[ $? == 0 ]] then ln -fs -T /home/$INACTIVE/sockets /home/test/sockets fi Does that not work? | |
| You might mean "set -eu", since -x does not care about terminating the script (at least in bash). From 'help set': -x Print commands and their arguments as they are executed. | |
| Oops, you're right of course. | |
| Addressed. Tests needed. | |
| fixed in 9cdd2685e9 | |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2016-06-07 17:27 | Florian Dold | New Issue | |
| 2016-06-07 17:27 | Florian Dold | Status | new => assigned |
| 2016-06-07 17:27 | Florian Dold | Assigned To | => Marcello Stanisci |
| 2016-06-17 13:58 | Marcello Stanisci | Note Added: 0010907 | |
| 2016-06-17 20:46 | Marcello Stanisci | Note Added: 0010910 | |
| 2016-06-17 20:58 | Florian Dold | Note Added: 0010911 | |
| 2016-06-17 21:23 | Marcello Stanisci | Note Added: 0010912 | |
| 2016-06-20 11:48 | Marcello Stanisci | Note Added: 0010915 | |
| 2016-06-20 11:48 | Marcello Stanisci | Status | assigned => informing |
| 2016-06-20 11:48 | Marcello Stanisci | Resolution | open => fixed |
| 2016-07-09 15:21 | Christian Grothoff | Product Version | => 0.0 |
| 2016-07-09 15:21 | Christian Grothoff | Fixed in Version | => 0.1 |
| 2016-07-09 15:21 | Christian Grothoff | Target Version | => 0.1 |
| 2016-10-11 15:28 | Christian Grothoff | Status | informing => closed |