View Issue Details

IDProjectCategoryView StatusLast Update
0004484Talerexchangepublic2016-05-03 10:37
ReporterFlorian Dold Assigned ToChristian Grothoff Resolution deadline
ImplementerReviewer 
Release signed byDeployed by 
VerifierCommunicator 
Data protection authority notification requiredNo  
CSIRT notification requiredNo  
Estimated effort (hours)Actual effort (hours)0 
Fast-trackNo
Work packagenone
PrioritynormalSeverityfeatureReproducibilityN/A
Status closedResolutionwon't fix 
Product Version0.0 
Target Version0.0Fixed in Version0.0 
Summary0004484: taler-exchange-dbinit does not check if schema is correct
DescriptionAfter running taler-exchange-dbinit, the exchange should run without any database access or schema problems.

Right now if the schema is out of date, only running the exchange will surface that problem.
TagsNo tags attached.

Required notifications

Address or linkRemarkAdded byNotifiedActions

Activities

Christian Grothoff

2016-05-03 03:48

manager   ~0010610

I'm not sure there is a generic perfect solution here. Basically, what you're asking for is to introduce schema versioning and migration. But even that can always be buggy. For now, given that we're not in production, it doesn't even make sense to bother with writing schema upgrade logic. So what exactly do you propose the change to be here?

Florian Dold

2016-05-03 09:28

manager   ~0010617

On second thought, what I'm proposing doesn't make much sense in the context of dbinit.

I just wanted a way to make sure that the database tables have the right schema *without* having to run actual HTTP requests that touch the database.

But that's not easily possible I guess ...

In the future we'd probably have some tool to check the database consistency which will also complain about a wrong schema, but for now we'll have to live with the exchange choking on a bad schema only after somebody made a request.

Issue History

Date ModifiedUsernameFieldChange
2016-05-02 13:26Florian DoldNew Issue
2016-05-02 13:26Florian DoldStatusnew => assigned
2016-05-02 13:26Florian DoldAssigned To => Christian Grothoff
2016-05-03 03:48Christian GrothoffNote Added: 0010610
2016-05-03 03:48Christian GrothoffAssigned ToChristian Grothoff =>
2016-05-03 03:48Christian GrothoffStatusassigned => feedback
2016-05-03 03:48Christian GrothoffProduct Version => 0.0
2016-05-03 03:48Christian GrothoffSeverityminor => feature
2016-05-03 09:28Florian DoldNote Added: 0010617
2016-05-03 09:28Florian DoldStatusfeedback => new
2016-05-03 10:37Christian GrothoffAssigned To => Christian Grothoff
2016-05-03 10:37Christian GrothoffReproducibilityhave not tried => N/A
2016-05-03 10:37Christian GrothoffStatusnew => closed
2016-05-03 10:37Christian GrothoffResolutionopen => won't fix
2016-05-03 10:37Christian GrothoffFixed in Version => 0.0
2016-05-03 10:37Christian GrothoffTarget Version => 0.0