View Issue Details

IDProjectCategoryView StatusLast Update
0004476Talerwallet (WebExtension)public2016-11-20 02:26
ReporterFlorian Dold Assigned ToFlorian Dold Resolution deadline
ImplementerReviewer 
Release signed byDeployed by 
VerifierCommunicator 
Data protection authority notification requiredNo  
CSIRT notification requiredNo  
Estimated effort (hours)Actual effort (hours)0 
Fast-trackNo
Work packagenone
PrioritynormalSeverityfeatureReproducibilityhave not tried
Status closedResolutionfixed 
Product Version0.0 
Target Version0.2Fixed in Version0.2 
Summary0004476: testcases for wallet backend library missing
DescriptionWe should test that library by mocking the database (which is not trivial, since IndexedDB is only completely implemented for browsers, but there's [1]) as well as the exchange.

[1] https://www.npmjs.com/package/indexeddb-js
TagsNo tags attached.

Required notifications

Address or linkRemarkAdded byNotifiedActions

Relationships

related to 0004477 closedFlorian Dold disentangle helper functions from wallet backend for better testability 

Activities

Florian Dold

2016-11-14 03:00

manager   ~0011490

The wallet logic can only reasonably tested with end-to-end tests or very complex mocks.

We do have test cases now for functionality that is easy to factor out from the db/http logic, e.g. for coin selection or the crypto. We can also have tests that run in the browser (with coverage!), so we can test our database abstraction layer.

The rest is mostly plumbing, and should be tested end-to-end (selenium) or with telemetry.

Issue History

Date ModifiedUsernameFieldChange
2016-04-27 14:41Florian DoldNew Issue
2016-04-27 14:41Florian DoldStatusnew => assigned
2016-04-27 14:41Florian DoldAssigned To => Florian Dold
2016-04-27 14:43Florian DoldRelationship addedrelated to 0004477
2016-05-04 13:49Christian GrothoffSeverityminor => feature
2016-05-04 13:49Christian GrothoffProduct Version => 0.0
2016-05-04 13:49Christian GrothoffTarget Version => 0.1
2016-09-27 20:27Christian GrothoffTarget Version0.1 => 0.2
2016-11-14 03:00Florian DoldNote Added: 0011490
2016-11-14 03:01Florian DoldStatusassigned => informing
2016-11-14 03:01Florian DoldResolutionopen => fixed
2016-11-15 15:03Christian GrothoffFixed in Version => 0.2
2016-11-20 02:26Christian GrothoffStatusinforming => closed
2023-04-13 18:37Florian DoldCategorywallet (WebExtensions) => wallet (WebExtension)