View Issue Details

IDProjectCategoryView StatusLast Update
0004453Talerotherpublic2019-12-20 18:12
ReporterFlorian Dold Assigned ToMarcello Stanisci Resolution deadline
ImplementerReviewer 
Release signed byDeployed by 
VerifierCommunicator 
Data protection authority notification requiredNo  
CSIRT notification requiredNo  
Estimated effort (hours)Actual effort (hours)0 
Fast-trackNo
Work packagenone
PrioritylowSeverityfeatureReproducibilityhave not tried
Status closedResolutionfixed 
Product Version0.0 
Target Version0.6Fixed in Version0.6 
Summary0004453: python components should respect loglevel
Description... in a way similar to GNUnet / the other Taler components
TagsNo tags attached.

Required notifications

Address or linkRemarkAdded byNotifiedActions

Activities

Marcello Stanisci

2018-09-21 09:23

reporter   ~0013250

You mean we want our pythons to:

1) have always a -L <loglev> CLI option
2) interpret some env variable having the same format of GNUNET_FORCE_LOG

?

Christian Grothoff

2019-02-02 09:51

manager   ~0013558

See also https://gnunet.org/logging

Marcello Stanisci

2019-02-06 14:20

reporter   ~0013614

Commit 3c42d73724a3ccbf2 (at copylib.git) implements the following things:

* interpretation of env var GNUNET_LOG
* interpretation of env var GNUNET_FORCE_LOG
* interpretation of env var GNUNET_FORCE_LOGFILE

and it does NOT do the following things:

* enforcing the 'file', 'function', 'from line[-to line]' fields of logging definitions
* adding any '-L' and '-l' CLI options. For this, I don't think it's the logger responsibility to deal with CLI arguments; rather, it should be some universal "wrapper" that adjusts such values for all the GNUnet-ish pythons (exactly like GNUNET_PROGRAM_run does). If we really want this, let's (first discuss and then) open a separate issue.

Marcello Stanisci

2019-02-06 18:22

reporter   ~0013620

b3de4b42a6cc6032 implemets the check on the other fields (line, function name, line range).

Keeping it open until proper testing will be implemented.

Marcello Stanisci

2019-02-07 15:47

reporter   ~0013623

be06e05..d3a6c1b finishes this issue (including all was missing).

Issue History

Date ModifiedUsernameFieldChange
2016-04-20 14:55Florian DoldNew Issue
2016-05-04 13:50Christian GrothoffSeverityminor => feature
2016-05-04 13:50Christian GrothoffProduct Version => 0.0
2016-05-04 13:50Christian GrothoffPrioritynormal => low
2016-05-04 13:50Christian GrothoffStatusnew => implementing
2017-03-18 22:35Christian GrothoffTarget Version => 0.7.1
2017-04-08 22:17Christian GrothoffTarget Version0.7.1 => 0.6
2018-09-15 09:08Christian GrothoffAssigned To => Marcello Stanisci
2018-09-15 09:08Christian GrothoffStatusimplementing => assigned
2018-09-21 09:23Marcello StanisciNote Added: 0013250
2019-02-02 09:51Christian GrothoffNote Added: 0013558
2019-02-06 14:20Marcello StanisciNote Added: 0013614
2019-02-06 18:22Marcello StanisciNote Added: 0013620
2019-02-07 15:47Marcello StanisciStatusassigned => informing
2019-02-07 15:47Marcello StanisciResolutionopen => fixed
2019-02-07 15:47Marcello StanisciNote Added: 0013623
2019-02-12 22:18Christian GrothoffFixed in Version => 0.6
2019-12-20 18:12Christian GrothoffStatusinforming => closed