View Issue Details

IDProjectCategoryView StatusLast Update
0004452Talertaler-merchant-demospublic2024-01-12 13:08
ReporterFlorian Dold Assigned ToMarcello Stanisci Resolution deadline
ImplementerReviewer 
Release signed byDeployed by 
VerifierCommunicator 
Data protection authority notification requiredNo  
CSIRT notification requiredNo  
Estimated effort (hours)Actual effort (hours)0 
Fast-trackNo
Work packagenone
PrioritynormalSeveritymajorReproducibilityhave not tried
Status closedResolutionfixed 
Product Version0.0 
Target Version0.0Fixed in Version0.0 
Summary0004452: merchant does not do contract restoration correctly
Description... basically right now the PHP merchants don't verify that the parameters (donation receiver, amount) match the contract with the given transaction id and hash.

Thus the merchant will happily generate pages like "You successfully donated 1000 KUDOS to FooBar", even though we never signed a contract mentioning FooBar or 1000 KUDOS.
TagsNo tags attached.

Required notifications

Address or linkRemarkAdded byNotifiedActions

Activities

Florian Dold

2016-04-20 01:54

manager   ~0010529

This is fixed in the Python merchant. I really don't want to touch the PHP code again ;-)

Marcello Stanisci

2016-04-22 18:54

reporter   ~0010546

to be tested with wallet

Marcello Stanisci

2016-05-02 11:51

reporter   ~0010606

fixed in af5c823 (although not mentioned in the commit message..)

Issue History

Date ModifiedUsernameFieldChange
2016-04-20 01:03Florian DoldNew Issue
2016-04-20 01:03Florian DoldStatusnew => assigned
2016-04-20 01:03Florian DoldAssigned To => Marcello Stanisci
2016-04-20 01:54Florian DoldNote Added: 0010529
2016-04-22 18:54Marcello StanisciNote Added: 0010546
2016-05-02 11:51Marcello StanisciNote Added: 0010606
2016-05-02 11:51Marcello StanisciStatusassigned => informing
2016-05-02 11:51Marcello StanisciResolutionopen => fixed
2016-05-03 03:57Christian GrothoffStatusinforming => closed
2016-05-03 03:57Christian GrothoffProduct Version => 0.0
2016-05-03 03:57Christian GrothoffFixed in Version => 0.0
2016-05-03 03:57Christian GrothoffTarget Version => 0.0
2024-01-12 13:08Christian GrothoffCategorymerchant frontend (donations) => Merchant frontends (Python3)
2026-08-23 14:16Florian DoldCategoryMerchant frontends (Python3) => taler-merchant-demos