View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0004445 | Taler | exchange | public | 2016-04-19 11:18 | 2016-04-24 21:42 |
| Reporter | Florian Dold | Assigned To | Christian Grothoff | Resolution deadline | |
| Implementer | Reviewer | ||||
| Release signed by | Deployed by | ||||
| Verifier | Communicator | ||||
| Data protection authority notification required | No | ||||
| CSIRT notification required | No | ||||
| Estimated effort (hours) | Actual effort (hours) | 0 | |||
| Fast-track | No | ||||
| Work package | none | ||||
| Priority | normal | Severity | minor | Reproducibility | have not tried |
| Status | closed | Resolution | fixed | ||
| Product Version | 0.0 | ||||
| Target Version | 0.0 | Fixed in Version | 0.0 | ||
| Summary | 0004445: ftbfs on a fresh debian jessie | ||||
| Description | configure doesn't complain, but apparently there's something wrong with lib(gn|c)url. | ||||
| Additional Information | CC plugin_wire_test.lo In file included from ../../src/include/taler_bank_service.h:26:0, from plugin_wire_test.c:24: /usr/local/include/gnunet/gnunet_curl_lib.h:141:22: error: unknown type name 'CURL' CURL *eh, ^ | ||||
| Tags | No tags attached. | ||||
| This might be related to how platform.h is handled, it was included (both in GNUnet and in the Taler exchange) in some places where it shouldn't be included (namely public headers). gnunet/platform.h includes the gnunet configuration header, which shares some of the same #defines as the taler exchange configuration header (but the code in configure.ac for setting those flags is not the same). Thus we might have included the wrong file in some places. | |
| Okay, so here's the problem: // gnunet_curl_lib.h #if HAVE_CURL_CURL_H #include <curl/curl.h> #elif HAVE_GNURL_CURL_H #include <gnurl/curl.h> #else // I've added this error #error "needs curl or gnurl" #endif we basically assume that HAVE_(GN|C)URL_CURL_H is defined before we include the header. So in the exchange, we need to include our platform header before including gnunet_curl_lib. | |
| fixed by changing the taler exchange configure.ac (also fixed some includes in GNUnet) | |
| Please report Git revisions in which bugs are resolved. | |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2016-04-19 11:18 | Florian Dold | New Issue | |
| 2016-04-19 11:18 | Florian Dold | Status | new => assigned |
| 2016-04-19 11:18 | Florian Dold | Assigned To | => Christian Grothoff |
| 2016-04-19 12:08 | Florian Dold | Note Added: 0010513 | |
| 2016-04-19 12:09 | Florian Dold | Note Edited: 0010513 | |
| 2016-04-19 12:09 | Florian Dold | Note Edited: 0010513 | |
| 2016-04-19 12:38 | Florian Dold | Note Added: 0010514 | |
| 2016-04-19 13:14 | Florian Dold | Note Added: 0010517 | |
| 2016-04-19 13:14 | Florian Dold | Status | assigned => informing |
| 2016-04-19 13:14 | Florian Dold | Resolution | open => fixed |
| 2016-04-24 21:42 | Christian Grothoff | Note Added: 0010554 | |
| 2016-04-24 21:42 | Christian Grothoff | Status | informing => closed |
| 2016-04-24 21:42 | Christian Grothoff | Product Version | => 0.0 |
| 2016-04-24 21:42 | Christian Grothoff | Fixed in Version | => 0.0 |
| 2016-04-24 21:42 | Christian Grothoff | Target Version | => 0.0 |