View Issue Details

IDProjectCategoryView StatusLast Update
0004422Talerobsolete componentpublic2016-04-15 15:14
ReporterChristian Grothoff Assigned ToFlorian Dold Resolution deadline
ImplementerReviewer 
Release signed byDeployed by 
VerifierCommunicator 
Data protection authority notification requiredNo  
CSIRT notification requiredNo  
Estimated effort (hours)Actual effort (hours)0 
Fast-trackNo
Work packagenone
PrioritynormalSeverityblockReproducibilityalways
Status closedResolutionfixed 
Platformi7OSDebian GNU/LinuxOS Versionsqueeze
Product Version0.0 
Target Version0.0Fixed in Version0.0 
Summary0004422: taler-bank-manage createdb fails (substitution error?)
Descriptiongrothoff@spec:~$ taler-bank-manage createdb
2016-04-15 15:55:40,398 settings INFO secret key not configured in TALER_BANK_SECRET_KEY env variable, generating random secret
psql: FATAL: database "@dbnamefinal@" does not exist
TagsNo tags attached.

Required notifications

Address or linkRemarkAdded byNotifiedActions

Activities

Christian Grothoff

2016-04-15 13:59

manager   ~0010480

Also, while we're at it, maybe the --with-dbname configure option (which I did NOT set in the run above) should be replaced with a config option in config.d/, as we do with everything else?

Florian Dold

2016-04-15 14:07

manager   ~0010483

You're right about the database name, it should be read from the config, I'll fix that.

I'm wondering though, should creation of the database be in taler-bank-manage anyway? At least on my system, I have to add additional permissions with psql, since my user can't actually create databases (by default).

I don't think other components of Taler create the database themselves, just the tables, right?

Florian Dold

2016-04-15 14:12

manager   ~0010484

In 3bc4d61, the database name is now read from the [bank]database config option.

I'd be in favour of just removing createdb, it's not consistent with the rest of taler, and requires guessing the system configuration (it won't work if only the postgres user can create databases).

Christian Grothoff

2016-04-15 14:40

manager   ~0010486

I'm fine with removing the option. We might want to consider just trying to automatically create it if we can, and otherwise prompt the user to run 'createdb'.

Florian Dold

2016-04-15 15:11

manager   ~0010490

In most cases the user needs to manually create the database with permissions anyway, and the exchange/merchant requires the same procedure.

At least for now, we shouldn't try to create the db automatically.

Issue History

Date ModifiedUsernameFieldChange
2016-04-15 13:57Christian GrothoffNew Issue
2016-04-15 13:57Christian GrothoffStatusnew => assigned
2016-04-15 13:57Christian GrothoffAssigned To => Florian Dold
2016-04-15 13:59Christian GrothoffNote Added: 0010480
2016-04-15 14:07Florian DoldNote Added: 0010483
2016-04-15 14:07Florian DoldStatusassigned => feedback
2016-04-15 14:12Florian DoldNote Added: 0010484
2016-04-15 14:40Christian GrothoffNote Added: 0010486
2016-04-15 14:40Christian GrothoffStatusfeedback => assigned
2016-04-15 15:11Florian DoldNote Added: 0010490
2016-04-15 15:11Florian DoldStatusassigned => informing
2016-04-15 15:11Florian DoldResolutionopen => fixed
2016-04-15 15:14Christian GrothoffStatusinforming => closed
2016-04-15 15:14Christian GrothoffFixed in Version => 0.0
2022-08-23 18:26Christian GrothoffCategorybank (demonstrator) => py bank (demonstrator, obsolete)
2023-12-03 00:23Christian GrothoffCategorypy bank (demonstrator, obsolete) => obsolete componet
2023-12-11 19:08Florian DoldCategoryobsolete componet => obsolete component