View Issue Details

IDProjectCategoryView StatusLast Update
0004418Talerwallet (WebExtension)public2016-04-28 20:15
ReporterFlorian Dold Assigned ToFlorian Dold Resolution deadline
ImplementerReviewer 
Release signed byDeployed by 
VerifierCommunicator 
Data protection authority notification requiredNo  
CSIRT notification requiredNo  
Estimated effort (hours)Actual effort (hours)0 
Fast-trackNo
Work packagenone
PrioritynormalSeverityminorReproducibilityhave not tried
Status closedResolutionfixed 
Product Version0.0 
Target Version0.0Fixed in Version0.0 
Summary0004418: integrate the istanbul code coverage checker with the wallet code base
DescriptionThis mostly involved adapting then build system so that it can generate code instrumented by istanbul.
TagsNo tags attached.

Required notifications

Address or linkRemarkAdded byNotifiedActions

Activities

Florian Dold

2016-04-27 13:36

manager   ~0010570

Istanbul is now integrated into the wallet, you can run

$ npm run test-cover

to do instrumented tests, and

$ istanbul report

to generate reports. Istanbul stores coverage information in the lcov format.

A minor flaw is that coverage is only supported for files loaded during the test cases, which means that the percentages are much higher than the actual test coverage.

Also source mapping to TypeScript is not integrated yet, but possible with https://github.com/SitePen/remap-istanbul

Issue History

Date ModifiedUsernameFieldChange
2016-04-14 15:39Florian DoldNew Issue
2016-04-14 15:39Florian DoldStatusnew => assigned
2016-04-14 15:39Florian DoldAssigned To => Florian Dold
2016-04-27 13:36Florian DoldNote Added: 0010570
2016-04-27 13:36Florian DoldStatusassigned => informing
2016-04-27 13:36Florian DoldResolutionopen => fixed
2016-04-28 20:15Christian GrothoffStatusinforming => closed
2016-04-28 20:15Christian GrothoffProduct Version => 0.0
2016-04-28 20:15Christian GrothoffFixed in Version => 0.0
2016-04-28 20:15Christian GrothoffTarget Version => 0.0
2023-04-13 18:37Florian DoldCategorywallet (WebExtensions) => wallet (WebExtension)