View Issue Details

IDProjectCategoryView StatusLast Update
0004403Talerexchangepublic2024-01-12 13:05
ReporterChristian Grothoff Assigned ToChristian Grothoff Resolution deadline
ImplementerReviewer 
Release signed byDeployed by 
VerifierCommunicator 
Data protection authority notification requiredNo  
CSIRT notification requiredNo  
Estimated effort (hours)Actual effort (hours)0 
Fast-trackNo
Work packagenone
PrioritynormalSeveritytweakReproducibilityN/A
Status closedResolutionfixed 
Platformi7OSDebian GNU/LinuxOS Versionsqueeze
Product Version0.0 
Target Version0.0Fixed in Version0.0 
Summary0004403: code duplication between bank_api_context.c and exchange_api_context.c
DescriptionThis is basically the 'context' stuff we wrap around libcurl. We should consider abstracting this into a libgnunetcurl or libtalercurl helper library to eliminate the code duplication.
TagsNo tags attached.

Required notifications

Address or linkRemarkAdded byNotifiedActions

Activities

Christian Grothoff

2016-04-17 15:46

manager   ~0010500

First part done:

$ git commit -a -m "replace exchange_api_context with libgnunetcurl"
[master 1ed567a] replace exchange_api_context with libgnunetcurl
 16 files changed, 189 insertions(+), 1093 deletions(-)
 delete mode 100644 src/exchange-lib/exchange_api_context.c
 delete mode 100644 src/exchange-lib/exchange_api_context.h
grothoff@spec:~/research/taler-exchange/src/exchange-lib$ git push
Counting objects: 19, done.
Delta compression using up to 8 threads.
Compressing objects: 100% (19/19), done.
Writing objects: 100% (19/19), 4.45 KiB | 0 bytes/s, done.
Total 19 (delta 17), reused 0 (delta 0)
To git+ssh://git@taler.net/var/git/exchange.git
   05751b6..1ed567a master -> master

Christian Grothoff

2016-04-17 16:05

manager   ~0010501

Deduplicated by moving shared logic to libgnunetcurl in 1ed567a..7496a03

Issue History

Date ModifiedUsernameFieldChange
2016-04-11 18:28Christian GrothoffNew Issue
2016-04-11 18:28Christian GrothoffStatusnew => assigned
2016-04-11 18:28Christian GrothoffAssigned To => Christian Grothoff
2016-04-17 15:46Christian GrothoffNote Added: 0010500
2016-04-17 16:05Christian GrothoffNote Added: 0010501
2016-04-17 16:05Christian GrothoffStatusassigned => informing
2016-04-17 16:05Christian GrothoffFixed in Version => 0.0
2016-04-17 16:05Christian GrothoffResolutionopen => fixed
2016-04-17 16:05Christian GrothoffStatusinforming => closed
2016-04-17 16:05Christian GrothoffTarget Version0.3 => 0.0
2024-01-12 13:05Christian GrothoffCategoryexchange API (C) => exchange