View Issue Details

IDProjectCategoryView StatusLast Update
0004364Talerwallet (WebExtension)public2016-10-11 15:28
ReporterFlorian Dold Assigned ToFlorian Dold Resolution deadline
ImplementerReviewer 
Release signed byDeployed by 
VerifierCommunicator 
Data protection authority notification requiredNo  
CSIRT notification requiredNo  
Estimated effort (hours)Actual effort (hours)0 
Fast-trackNo
Work packagenone
PrioritynormalSeverityfeatureReproducibilityhave not tried
Status closedResolutionfixed 
Product Version0.0 
Target Version0.1Fixed in Version0.1 
Summary0004364: figure out a strategy to deal with npm packages in automated builds and deployment
DescriptionWe should use npm only for development, not for deployment, due to the integrity and availability problems it has. There are three options:

1. move away from npm, use more reproducible package managers for big compile-time dependencies and vendor run-time dependencies
2. run our own npm mirror/cache (e.g. [1])
3. check node_modules into our repository (non-built, npm install --ignore-scripts)

Option 1 is probably what we should do in the long term, option 2 probably requires too much maintenance, and option 3 makes the repository way to large (it adds about 60mb).



[1] https://github.com/mixu/npm_lazy
TagsNo tags attached.

Required notifications

Address or linkRemarkAdded byNotifiedActions

Activities

Florian Dold

2016-04-22 21:45

manager   ~0010547

maybe somewhat ironically, npm itself [1] just checks in its node_modules into git. We should just do that then ...

Florian Dold

2016-10-10 01:45

manager   ~0011283

Addressed in abd94a7f. Increases the repo size by 5MB.

Some future dependencies may require

$ npm build

to be run when they have post-install scripts.

Issue History

Date ModifiedUsernameFieldChange
2016-04-05 14:27Florian DoldNew Issue
2016-04-05 14:27Florian DoldStatusnew => assigned
2016-04-05 14:27Florian DoldAssigned To => Florian Dold
2016-04-06 07:41Christian GrothoffSeverityminor => feature
2016-04-06 07:41Christian GrothoffProduct Version => 0.0
2016-04-13 22:58Christian GrothoffTarget Version => 0.1
2016-04-22 21:45Florian DoldNote Added: 0010547
2016-05-31 07:51Christian GrothoffTarget Version0.1 => 0.4
2016-10-10 01:45Florian DoldNote Added: 0011283
2016-10-10 01:45Florian DoldStatusassigned => informing
2016-10-10 01:45Florian DoldResolutionopen => fixed
2016-10-10 06:27Christian GrothoffFixed in Version => 0.1
2016-10-10 06:27Christian GrothoffTarget Version0.4 => 0.1
2016-10-11 15:28Christian GrothoffStatusinforming => closed
2023-04-13 18:37Florian DoldCategorywallet (WebExtensions) => wallet (WebExtension)