View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0004206 | Taler | wallet (WebExtension) | public | 2016-02-24 16:46 | 2016-03-19 11:51 |
| Reporter | Christian Grothoff | Assigned To | Florian Dold | Resolution deadline | |
| Implementer | Reviewer | ||||
| Release signed by | Deployed by | ||||
| Verifier | Communicator | ||||
| Data protection authority notification required | No | ||||
| CSIRT notification required | No | ||||
| Estimated effort (hours) | Actual effort (hours) | 0 | |||
| Fast-track | No | ||||
| Work package | none | ||||
| Priority | normal | Severity | text | Reproducibility | always |
| Status | closed | Resolution | no change required | ||
| Platform | i7 | OS | Debian GNU/Linux | OS Version | squeeze |
| Product Version | 0.0 | ||||
| Target Version | 0.0 | Fixed in Version | 0.0 | ||
| Summary | 0004206: Wallet contains unexpected strings for translation... | ||||
| Description | Looking at the PO files for translation, I see: msgid "Your balance on %1$s is %2$s KUDO. Get more at %3$s" msgid "free KUDOS" This surprises me greatly, as the currency should never be hardcoded in the wallet but come from the 'amount' object (as it could be EUR, or KUDOS, or whatever). So this ought to be fixed ASAP. | ||||
| Tags | No tags attached. | ||||
| This isn't really surprising at all: When there is no balance to be shown, we render what's called an "empty state" instead of just the empty table. It's good usability practice to not just say "oh, you have no balance, sorry" in the empty state, but also present the user with some action. Right now the "[...] do you want to get some free KUDOS", with a link pointing to our demo site, seems like a reasonable action for the empty state. Of course I'm open to better suggestions :-) | |
| Why mention the currency or the demo site? Just say: You should visit a bank to transfer coins to your wallet. For details, see [link to taler documentation]. Preferably the link goes to some chapter in a handbook from our texinfo manual, explaining the two ways for withdrawing coins from a bank (integrated, vs. manual), and THERE we can then refer to the demo. | |
| Oh, and the "Your balance on %1$s is %2$s KUDO. Get more at %3$s" is something that tg added as a ... erm ... test case interspersed with the code, guarded by an if (i18nDebug). This should be removed in general, but has nothing to do with the strings. | |
| Christian, I agree that eventually a link to the documentation should be there. I still think that a direct link to some demo bank site makes more sense for a demo prototype, since we won't lose people who do not have the attention span to look through some documentation and then discover that there's actually a demo bank that you can use. Maybe, as a compromise, we should remove the KUDOS in the copy and instead say something like "Withdraw some free coins at our demo bank" or something to that effect? Would you be okay with that? | |
| How about just putting a link [help] or something like that that points to 'https://taler.net/help/empty-wallet' and then for now we configure nginx to redirect /help/empty-wallet to the bank.demo site? That way, we can put help links to /help/TOPIC already, and "later" fill those help sites with the proper information. | |
| Changed to "You have no balance to show. Need some ${helpLink}? getting started?" | |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2016-02-24 16:46 | Christian Grothoff | New Issue | |
| 2016-02-24 16:46 | Christian Grothoff | Status | new => assigned |
| 2016-02-24 16:46 | Christian Grothoff | Assigned To | => Florian Dold |
| 2016-02-24 17:01 | Florian Dold | Note Added: 0010181 | |
| 2016-02-24 17:01 | Florian Dold | Status | assigned => informing |
| 2016-02-24 17:01 | Florian Dold | Resolution | open => no change required |
| 2016-02-24 17:04 | Christian Grothoff | Note Added: 0010182 | |
| 2016-02-24 17:04 | Christian Grothoff | Status | informing => assigned |
| 2016-02-24 17:07 | Florian Dold | Note Added: 0010183 | |
| 2016-02-24 17:12 | Florian Dold | Note Added: 0010184 | |
| 2016-03-15 19:20 | Christian Grothoff | Note Added: 0010244 | |
| 2016-03-18 16:44 | Florian Dold | Note Added: 0010249 | |
| 2016-03-18 16:44 | Florian Dold | Status | assigned => informing |
| 2016-03-19 11:50 | Christian Grothoff | Fixed in Version | => 0.0 |
| 2016-03-19 11:51 | Christian Grothoff | Status | informing => closed |
| 2023-04-13 18:37 | Florian Dold | Category | wallet (WebExtensions) => wallet (WebExtension) |