View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0004133 | Taler | other | public | 2016-01-12 17:10 | 2016-05-31 16:05 |
| Reporter | Florian Dold | Assigned To | Christian Grothoff | Resolution deadline | |
| Implementer | Reviewer | ||||
| Release signed by | Deployed by | ||||
| Verifier | Communicator | ||||
| Data protection authority notification required | No | ||||
| CSIRT notification required | No | ||||
| Estimated effort (hours) | Actual effort (hours) | 0 | |||
| Fast-track | No | ||||
| Work package | none | ||||
| Priority | normal | Severity | tweak | Reproducibility | have not tried |
| Status | closed | Resolution | fixed | ||
| Product Version | 0.0 | ||||
| Target Version | 0.0 | Fixed in Version | 0.0 | ||
| Summary | 0004133: TypeScript not compiled by the merchant make script | ||||
| Description | We somehow need to integrate compilation of the merchant front-end TypeScript code to JavaScript into the build system. This way we can finally remove all auto-generated JavaScript from the git repo. | ||||
| Tags | No tags attached. | ||||
| Eh, I cannot find said type script code. Where is it? | |
| The web-common.git now has taler-wallet-lib.ts as of 48d81d. Many other repositories use this via submodules. While that module works with older TypeScript versions, we're using 1.9.0-dev.20160311 for the wallet. It's compiled with $ tsc taler-wallet-lib.ts Note that there will be errors/warnings during compilation, since I've basically just renamed .js->.ts, but the JavaScript output will still be useable despite that. We should of course fix these / use proper typescript eventually. | |
| Compilation fails for me: $ tsc taler-wallet-lib.ts taler-wallet-lib.ts(27,20): error TS2339: Property 'taler' does not exist on type 'Window'. taler-wallet-lib.ts(161,13): error TS2339: Property 'style' does not exist on type 'Element'. taler-wallet-lib.ts(164,13): error TS2339: Property 'style' does not exist on type 'Element'. taler-wallet-lib.ts(167,17): error TS2339: Property 'disabled' does not exist on type 'Element'. taler-wallet-lib.ts(176,13): error TS2339: Property 'style' does not exist on type 'Element'. taler-wallet-lib.ts(179,13): error TS2339: Property 'style' does not exist on type 'Element'. taler-wallet-lib.ts(182,17): error TS2339: Property 'disabled' does not exist on type 'Element'. taler-wallet-lib.ts(219,7): error TS2304: Cannot find name 'uninstall_called'. Makefile:468: recipe for target 'taler-wallet-lib.js' failed | |
| It was supposed to fail, the generated JavaScript is still usable. Still, it makes sense for make to fail when the TypeScript code doesn't typecheck, I've "fixed" those errors in c16fe1b. | |
| Ok, I've modified the build systems in the various directories that use web-common now. It's still overall rather ugly, but should at least work for now. | |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2016-01-12 17:10 | Florian Dold | New Issue | |
| 2016-01-21 08:03 | Christian Grothoff | Severity | minor => tweak |
| 2016-01-21 08:03 | Christian Grothoff | Status | new => implementing |
| 2016-01-21 08:03 | Christian Grothoff | Product Version | => 0.0 |
| 2016-01-21 08:03 | Christian Grothoff | Target Version | => 0.0 |
| 2016-01-21 14:46 | Christian Grothoff | Target Version | 0.0 => 0.1 |
| 2016-01-22 22:43 | Christian Grothoff | Assigned To | => Florian Dold |
| 2016-01-22 22:43 | Christian Grothoff | Status | implementing => assigned |
| 2016-03-20 20:53 | Torsten Grothoff | Issue cloned: 0004306 | |
| 2016-05-31 07:57 | Christian Grothoff | Assigned To | Florian Dold => Christian Grothoff |
| 2016-05-31 08:25 | Christian Grothoff | Note Added: 0010806 | |
| 2016-05-31 08:26 | Christian Grothoff | Status | assigned => feedback |
| 2016-05-31 12:19 | Florian Dold | Note Added: 0010811 | |
| 2016-05-31 12:19 | Florian Dold | Status | feedback => assigned |
| 2016-05-31 12:20 | Florian Dold | Note Edited: 0010811 | |
| 2016-05-31 15:24 | Christian Grothoff | Note Added: 0010817 | |
| 2016-05-31 15:30 | Florian Dold | Note Added: 0010818 | |
| 2016-05-31 16:04 | Christian Grothoff | Note Added: 0010819 | |
| 2016-05-31 16:04 | Christian Grothoff | Status | assigned => informing |
| 2016-05-31 16:04 | Christian Grothoff | Fixed in Version | => 0.0 |
| 2016-05-31 16:04 | Christian Grothoff | Resolution | open => fixed |
| 2016-05-31 16:05 | Christian Grothoff | Status | informing => closed |
| 2016-05-31 16:05 | Christian Grothoff | Target Version | 0.1 => 0.0 |