View Issue Details

IDProjectCategoryView StatusLast Update
0004114Talerwallet (WebExtension)public2016-05-24 18:48
ReporterFlorian Dold Assigned ToFlorian Dold Resolution deadline
ImplementerReviewer 
Release signed byDeployed by 
VerifierCommunicator 
Data protection authority notification requiredNo  
CSIRT notification requiredNo  
Estimated effort (hours)Actual effort (hours)0 
Fast-trackNo
Work packagenone
PrioritynormalSeveritytweakReproducibilityhave not tried
Status closedResolutionfixed 
Product Version0.0 
Target Version0.0Fixed in Version0.0 
Summary0004114: stop using wrapper functions
DescriptionThe WX wallet already makes minimal use of emscripten wrapper functions. We should stop using wrapper functions altogether.

The extra wrapper functions are just maintenance overhead, having everything inside TypeScript is easier and safer in most cases.
TagsNo tags attached.

Required notifications

Address or linkRemarkAdded byNotifiedActions

Activities

Florian Dold

2016-05-23 23:42

manager   ~0010722

Mostly addressed in f98ceef.

There are about 55 lines of wrapper code left, but since JavaScript doesn't handle 64bit integers natively, they are necessary. Removing them would mean we'd have to manually do 64bit arithmetic and string/number conversion in JS.

Issue History

Date ModifiedUsernameFieldChange
2015-12-25 21:47Florian DoldNew Issue
2015-12-25 21:47Florian DoldStatusnew => assigned
2015-12-25 21:47Florian DoldAssigned To => Florian Dold
2016-01-22 22:20Christian GrothoffSeverityminor => tweak
2016-01-22 22:20Christian GrothoffProduct Version => 0.0
2016-01-22 22:20Christian GrothoffTarget Version => 0.1
2016-03-20 20:53Torsten GrothoffIssue cloned: 0004311
2016-05-23 23:42Florian DoldNote Added: 0010722
2016-05-23 23:42Florian DoldStatusassigned => informing
2016-05-23 23:42Florian DoldResolutionopen => fixed
2016-05-24 18:48Christian GrothoffStatusinforming => closed
2016-05-24 18:48Christian GrothoffFixed in Version => 0.0
2016-05-24 18:48Christian GrothoffTarget Version0.1 => 0.0
2023-04-13 18:37Florian DoldCategorywallet (WebExtensions) => wallet (WebExtension)