View Issue Details

IDProjectCategoryView StatusLast Update
0004109Talermerchant backendpublic2016-05-26 12:45
ReporterFlorian Dold Assigned ToMarcello Stanisci Resolution deadline
ImplementerReviewer 
Release signed byDeployed by 
VerifierCommunicator 
Data protection authority notification requiredNo  
CSIRT notification requiredNo  
Estimated effort (hours)Actual effort (hours)0 
Fast-trackNo
Work packagenone
PriorityurgentSeveritycrashReproducibilityhave not tried
Status closedResolutionno change required 
Product Version0.0 
Target Version0.0Fixed in Version0.0 
Summary0004109: requesting invalid /pay twice causes merchant to crash
DescriptionWhen refreshing the failed payment page in the wallet twice (which requests /pay from the merchant), the merchant crashes (see Additional Information).
Additional InformationDec 25 15:35:33-841821 taler-merchant-httpd-2745 DEBUG In mint context polling task, max_fd=11, timeout=1
Dec 25 15:35:33-845817 util-scheduler-2745 ERROR `select' failed at scheduler.c:799 with error: Bad file descriptor
Dec 25 15:35:33-846644 taler-merchant-httpd-2745 ERROR Assertion failed at scheduler.c:855.
==2745==
==2745== Process terminating with default action of signal 6 (SIGABRT)
==2745== at 0x76BE5F8: raise (in /usr/lib/libc-2.22.so)
==2745== by 0x76BFA79: abort (in /usr/lib/libc-2.22.so)
==2745== by 0x628D988: GNUNET_abort_ (common_logging.c:290)
==2745== by 0x62BE7B3: GNUNET_SCHEDULER_run (scheduler.c:733)
==2745== by 0x62B9C2D: GNUNET_PROGRAM_run2 (program.c:302)
==2745== by 0x62B9F0E: GNUNET_PROGRAM_run (program.c:341)
==2745== by 0x403C54: main (taler-merchant-httpd.c:586)
==2745==
==2745== HEAP SUMMARY:
==2745== in use at exit: 388,206 bytes in 4,059 blocks
==2745== total heap usage: 382,748 allocs, 378,689 frees, 12,317,490 bytes allocated
==2745==
==2745== LEAK SUMMARY:
==2745== definitely lost: 968 bytes in 7 blocks
==2745== indirectly lost: 38,208 bytes in 388 blocks
==2745== possibly lost: 1,086 bytes in 32 blocks
==2745== still reachable: 347,944 bytes in 3,632 blocks
==2745== suppressed: 0 bytes in 0 blocks
==2745== Rerun with --leak-check=full to see details of leaked memory
==2745==
==2745== For counts of detected and suppressed errors, rerun with: -v
==2745== ERROR SUMMARY: 0 errors from 0 contexts (suppressed: 0 from 0)
Aborted (core dumped)
TagsNo tags attached.

Required notifications

Address or linkRemarkAdded byNotifiedActions

Relationships

related to 0004070 closedMarcello Stanisci need unit testcases for libtalermerchantdb 

Activities

Florian Dold

2015-12-25 15:10

manager   ~0010037

Probably related to the memory corruption from 0004110, seems to be fixed now.

Florian Dold

2015-12-25 15:35

manager   ~0010038

Okay, this is not gone yet, I got then crash again ...

Christian Grothoff

2015-12-25 18:21

manager   ~0010039

Hmm. Seems most likely that somehow we close the FD of the connection, but do not properly update the scheduler's event loop, so that one still has the old socket in the select()-set, which triggers the assertion.

Christian Grothoff

2016-03-19 18:44

manager   ~0010253

As this hasn't been reproduced, I'm re-assigning to Marcello, as this falls into testing the merchant (and thus is a bit with 0004070).

Christian Grothoff

2016-05-26 12:45

manager   ~0010765

Seems fixed for real.

Issue History

Date ModifiedUsernameFieldChange
2015-12-25 14:39Florian DoldNew Issue
2015-12-25 14:39Florian DoldStatusnew => assigned
2015-12-25 14:39Florian DoldAssigned To => Marcello Stanisci
2015-12-25 15:10Florian DoldNote Added: 0010037
2015-12-25 15:10Florian DoldStatusassigned => informing
2015-12-25 15:10Florian DoldResolutionopen => no change required
2015-12-25 15:10Florian DoldAssigned ToMarcello Stanisci => Florian Dold
2015-12-25 15:35Florian DoldNote Added: 0010038
2015-12-25 15:35Florian DoldStatusinforming => new
2015-12-25 18:21Christian GrothoffNote Added: 0010039
2015-12-25 18:22Christian GrothoffStatusnew => acknowledged
2015-12-25 18:22Christian GrothoffProduct Version => 0.0
2015-12-25 18:22Christian GrothoffTarget Version => 0.0
2016-01-22 22:53Christian GrothoffTarget Version0.0 => 0.1
2016-03-19 18:43Christian GrothoffAssigned ToFlorian Dold => Marcello Stanisci
2016-03-19 18:43Christian GrothoffStatusacknowledged => assigned
2016-03-19 18:44Christian GrothoffNote Added: 0010253
2016-03-19 18:44Christian GrothoffRelationship addedrelated to 0004070
2016-03-20 20:53Torsten GrothoffIssue cloned: 0004255
2016-05-26 12:45Christian GrothoffNote Added: 0010765
2016-05-26 12:45Christian GrothoffStatusassigned => closed
2016-05-26 12:45Christian GrothoffFixed in Version => 0.0
2016-05-26 12:45Christian GrothoffTarget Version0.1 => 0.0
2025-03-22 13:09Christian GrothoffCategorymechant backend => merchant backend