View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0004039 | Taler | exchange | public | 2015-10-30 13:34 | 2015-11-12 19:42 |
| Reporter | Jeff Burdges | Assigned To | Christian Grothoff | Resolution deadline | |
| Implementer | Reviewer | ||||
| Release signed by | Deployed by | ||||
| Verifier | Communicator | ||||
| Data protection authority notification required | No | ||||
| CSIRT notification required | No | ||||
| Estimated effort (hours) | Actual effort (hours) | 0 | |||
| Fast-track | No | ||||
| Work package | none | ||||
| Priority | high | Severity | minor | Reproducibility | have not tried |
| Status | closed | Resolution | fixed | ||
| Product Version | 0.0 | ||||
| Target Version | 0.0 | Fixed in Version | 0.0 | ||
| Summary | 0004039: Mint API spec changed | ||||
| Description | Taler API commit c4151f993efcd1b62e6387800f2617dd4c276ce8 removes the final usage of JSON object style signatures from the mint API. The mint code should be changed to conform. This should simplify the code. | ||||
| Tags | No tags attached. | ||||
| Did you push? api.taler.net seems to at least not have been updated (yet). | |
| Something was pushed, but I still see this: signature (object) – signature (full object with all details) made with purpose TALER_SIGNATURE_WALLET_RESERVE_WITHDRAW made with the reserve’s public key over the original “WITHDRAW” request, present if the type was “WITHDRAW” | |
| The original commit Jeff referred to is here: http://www.git.taler.net/?p=api.git;a=commitdiff;h=c4151f993efcd1b62e6387800f2617dd4c276ce8 | |
| Oops. Now fixed in 3f18953a21019015c4ea748c0f9e3cdd00abb93e | |
| And now 592cbd14f6f0f8ffef70091801ca73ce07545141 as I botched the sig description the first time around | |
| Fixed in Git. The changes to the spec also did simplify the code (-100 lines!). $ git commit -a -m "updating code to match simplified specification (0004039)" [master 9bbfca5] updating code to match simplified specification (0004039) 7 files changed, 121 insertions(+), 212 deletions(-) $ git push Counting objects: 14, done. Delta compression using up to 8 threads. Compressing objects: 100% (14/14), done. Writing objects: 100% (14/14), 2.08 KiB | 0 bytes/s, done. Total 14 (delta 13), reused 0 (delta 0) To git+ssh://git@taler.net/var/git/mint.git e5988bf..9bbfca5 master -> master | |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2015-10-30 13:34 | Jeff Burdges | New Issue | |
| 2015-10-30 21:42 | Christian Grothoff | Assigned To | => Christian Grothoff |
| 2015-10-30 21:42 | Christian Grothoff | Status | new => assigned |
| 2015-11-08 18:43 | Christian Grothoff | Priority | normal => high |
| 2015-11-08 18:43 | Christian Grothoff | Product Version | => 0.0 |
| 2015-11-08 18:43 | Christian Grothoff | Target Version | => 0.0 |
| 2015-11-08 18:49 | Christian Grothoff | Note Added: 0009877 | |
| 2015-11-08 18:52 | Christian Grothoff | Note Added: 0009878 | |
| 2015-11-09 09:25 | Christian Grothoff | Note Added: 0009879 | |
| 2015-11-10 15:46 | Jeff Burdges | Note Added: 0009882 | |
| 2015-11-10 15:50 | Jeff Burdges | Note Added: 0009883 | |
| 2015-11-11 13:46 | Christian Grothoff | Note Added: 0009886 | |
| 2015-11-11 13:46 | Christian Grothoff | Status | assigned => informing |
| 2015-11-11 13:46 | Christian Grothoff | Fixed in Version | => 0.0 |
| 2015-11-11 13:46 | Christian Grothoff | Resolution | open => fixed |
| 2015-11-12 19:42 | Christian Grothoff | Status | informing => closed |
| 2016-02-18 14:43 | Christian Grothoff | Category | mint => exchange |