View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0004013 | Taler | taler-merchant-demos | public | 2015-10-20 12:21 | 2024-01-12 13:08 |
| Reporter | Marcello Stanisci | Assigned To | Marcello Stanisci | Resolution deadline | |
| Implementer | Reviewer | ||||
| Release signed by | Deployed by | ||||
| Verifier | Communicator | ||||
| Data protection authority notification required | No | ||||
| CSIRT notification required | No | ||||
| Estimated effort (hours) | Actual effort (hours) | 0 | |||
| Fast-track | No | ||||
| Work package | none | ||||
| Priority | high | Severity | tweak | Reproducibility | have not tried |
| Status | closed | Resolution | fixed | ||
| Product Version | 0.0 | ||||
| Target Version | 0.0 | Fixed in Version | 0.0 | ||
| Summary | 0004013: Code modifications | ||||
| Description | Two are the main points for this issue: 1) As of now, the merchant backend is a unique function called 'url_handler' which serves all the requests, and defines *a lot* of variables on the stack. The modification should define a dedicated handler for each "/x" made available by the merchant, in order to make 'url_handler' more light. (ADDED) 2) The merchant should monitor the reference count of each 'json_t *' type used | ||||
| Tags | No tags attached. | ||||
| related to | 0004021 | closed | Marcello Stanisci | Backend modifications to match new API |
| related to | 0004012 | closed | Marcello Stanisci | Verify deposit confirmation signature |
| related to | 0004011 | closed | Marcello Stanisci | Get mint's "/keys" |
| related to | 0004016 | closed | Marcello Stanisci | Change implementation |
| 3) correcting compilation 'warnings' (FIXED) | |
| 4) convert various 'printf's in 'GNUNET_log's - See https://gnunet.org/logging for instructions on how to enable and configure this facility update: configure ignores --enable-logging --enable-logging=verbose | |
| 'related to' as in 'fix before' (the issues it got related to). | |
| 5) Define struct(s) to group recurrent data "aggregates" in the code. This modification makes functions taking n+j argument, take just j+1, by substituting n arguments belonging to the same aggregate with some 'struct' which groupes them. For example, define a 'struct' which represents a contract in DB. NOTE: the refactored merchant doesn't use anything from the "old" library, so this hint doesn't apply. (ADDED) | |
| point 1) ADDED | |
| ***BUG UPDATE:*** the points still applying are: 1) count 'json_t *' references 2) get GNUNET_ERROR_TYPE_INFO printed | |
| Run $ export GNUNET_FORCE_LOG=";;;;INFO" before running command, and you'll see those. | |
| GNUNET_log_setup() sets the "minimal" log level globally, with the export you override. See https://gnunet.org/logging | |
| I think this is all fine now. | |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2015-10-20 12:21 | Marcello Stanisci | New Issue | |
| 2015-10-20 12:21 | Marcello Stanisci | Status | new => assigned |
| 2015-10-20 12:21 | Marcello Stanisci | Assigned To | => Marcello Stanisci |
| 2015-10-20 12:55 | Marcello Stanisci | Note Added: 0009757 | |
| 2015-10-20 13:12 | Marcello Stanisci | Note Added: 0009758 | |
| 2015-10-22 23:12 | Christian Grothoff | Severity | minor => tweak |
| 2015-10-22 23:12 | Christian Grothoff | Product Version | => 0.0 |
| 2015-10-22 23:12 | Christian Grothoff | Target Version | => 0.0 |
| 2015-10-23 12:56 | Marcello Stanisci | Relationship added | related to 0004021 |
| 2015-10-23 12:57 | Marcello Stanisci | Relationship added | related to 0004012 |
| 2015-10-23 12:57 | Marcello Stanisci | Relationship added | related to 0004011 |
| 2015-10-23 13:01 | Marcello Stanisci | Note Added: 0009780 | |
| 2015-10-23 13:03 | Marcello Stanisci | Note Edited: 0009780 | |
| 2015-10-23 13:15 | Marcello Stanisci | Relationship added | related to 0004016 |
| 2015-10-23 13:16 | Marcello Stanisci | Priority | normal => high |
| 2015-10-23 15:19 | Marcello Stanisci | Note Edited: 0009758 | |
| 2015-10-23 15:56 | Marcello Stanisci | Note Edited: 0009758 | |
| 2015-10-23 19:02 | Marcello Stanisci | Note Added: 0009785 | |
| 2015-10-27 09:09 | Marcello Stanisci | Note Edited: 0009757 | |
| 2015-10-30 06:42 | Marcello Stanisci | Note Added: 0009861 | |
| 2015-11-03 16:49 | Marcello Stanisci | Note Edited: 0009785 | |
| 2015-11-03 16:49 | Marcello Stanisci | Note Edited: 0009785 | |
| 2015-11-03 16:53 | Marcello Stanisci | Description Updated | |
| 2015-11-17 13:52 | Marcello Stanisci | Note Added: 0009915 | |
| 2015-11-17 14:27 | Christian Grothoff | Note Added: 0009918 | |
| 2015-11-17 14:28 | Christian Grothoff | Note Added: 0009919 | |
| 2015-11-27 20:30 | Christian Grothoff | Note Added: 0009953 | |
| 2015-11-27 20:30 | Christian Grothoff | Status | assigned => informing |
| 2015-11-27 20:30 | Christian Grothoff | Fixed in Version | => 0.0 |
| 2015-11-27 20:30 | Christian Grothoff | Resolution | open => fixed |
| 2015-11-28 21:28 | Christian Grothoff | Status | informing => closed |
| 2015-11-29 12:48 | Christian Grothoff | Category | merchant (demonstrator) => merchant frontend (demonstrator) |
| 2016-02-17 02:24 | Florian Dold | Category | merchant frontend (demonstrator) => merchant frontend (donations) |
| 2024-01-12 13:08 | Christian Grothoff | Category | merchant frontend (donations) => Merchant frontends (Python3) |
| 2026-08-23 14:16 | Florian Dold | Category | Merchant frontends (Python3) => taler-merchant-demos |