View Issue Details

IDProjectCategoryView StatusLast Update
0004005Talerwallet (WebExtension)public2016-02-19 20:33
ReporterMarcello Stanisci Assigned ToFlorian Dold Resolution deadline
ImplementerReviewer 
Release signed byDeployed by 
VerifierCommunicator 
Data protection authority notification requiredNo  
CSIRT notification requiredNo  
Estimated effort (hours)Actual effort (hours)0 
Fast-trackNo
Work packagenone
PrioritynormalSeverityminorReproducibilityhave not tried
Status closedResolutionno change required 
Product Version0.0 
Target Version0.0Fixed in Version0.0 
Summary0004005: Mark reserve as "defunct" after successful withdrawal
DescriptionInhibit the reserve, by marking it as empty or by removing
it (from DB), after the wallet withdraws all the money in it.
TagsNo tags attached.

Required notifications

Address or linkRemarkAdded byNotifiedActions

Activities

Marcello Stanisci

2015-10-14 11:10

reporter   ~0009727

In the current implementation, the reserve has the three columns
'value, fraction, currency' indicating the amount wired to the mint
for its creation. Since every withdrawal goes asynchronously, there
is no "central" point where it would be possible to detect whether
any withdrawal went fine. A solution might be that each withdrawal just
subtracts its amount from the reserve's. That way, if the amount drops
to zero, then the reserve's row could be deleted (or accordingly managed),
otherwise, the wallet maintains a reference to a non-emptied reserve
(still to be accordingly managed).

Christian Grothoff

2015-10-17 22:58

manager   ~0009740

Actually, that doesn't work as you don't know if the user deposited more than indicated, or did another deposit later. The safest thing to do is to have a timeout, i.e. reserve not used for x months, and then check /reserve/status and if it is zero and the reserve has been unused for like a year, then we can drop the column.

Florian Dold

2016-02-01 14:57

manager   ~0010124

This should already work in the WebEx wallet. It needs more testing though ...

Florian Dold

2016-02-18 23:54

manager   ~0010158

Reserves in the WebEx wallet are not directly visible in the UI, all coins are automatically withdrawn.

Once 0004126 and 0004188 are fixed, reserves will always be completely emptied (even with restarts inbetween) and then deleted.

Issue History

Date ModifiedUsernameFieldChange
2015-10-13 20:55Marcello StanisciNew Issue
2015-10-13 20:55Marcello StanisciStatusnew => assigned
2015-10-13 20:55Marcello StanisciAssigned To => Marcello Stanisci
2015-10-14 11:10Marcello StanisciNote Added: 0009727
2015-10-16 14:21Marcello StanisciTarget Version => 0.1
2015-10-17 22:58Christian GrothoffNote Added: 0009740
2015-10-22 23:13Christian GrothoffProduct Version => 0.0
2016-01-22 12:33Marcello StanisciAssigned ToMarcello Stanisci => Florian Dold
2016-01-22 12:33Marcello StanisciCategorywallet (browser-based) => wallet (WebExtensions)
2016-02-01 14:57Florian DoldNote Added: 0010124
2016-02-18 23:54Florian DoldNote Added: 0010158
2016-02-18 23:54Florian DoldStatusassigned => informing
2016-02-18 23:54Florian DoldResolutionopen => no change required
2016-02-19 20:33Christian GrothoffFixed in Version => 0.0
2016-02-19 20:33Christian GrothoffTarget Version0.1 => 0.0
2016-02-19 20:33Christian GrothoffStatusinforming => closed
2023-04-13 18:37Florian DoldCategorywallet (WebExtensions) => wallet (WebExtension)