View Issue Details

IDProjectCategoryView StatusLast Update
0003893libmicrohttpdHTTPS (TLS)public2021-09-02 15:54
Reportermatwey Assigned ToChristian Grothoff Due Date
PrioritynormalSeverityminorReproducibilityalways
Status closedResolutionfixed 
Product Version0.9.42 
Target Version0.9.43Fixed in Version0.9.43 
Summary0003893: CURL_SSLVERSION_TLSv1_1 is used when libcurl > 7.16.4 is required
DescriptionUnit test in testcurl/https/test_https_session_info.c uses CURL_SSLVERSION_TLSv1_1 which is came from libcurl > 7.34
At the same time configure.ac requires libcurl to be > 7.16.4.
Attempts to compile tests with libcurl between 7.16.4 and 7.34 lead to compile failure.
Attached here is a patch to introduce compile time guards with respect to libcurl version used.
TagsNo tags attached.
Attached Files
libmicrohttpd_test_session.patch (963 bytes)   
Index: libmicrohttpd-0.9.42/src/testcurl/https/test_https_session_info.c
===================================================================
--- libmicrohttpd-0.9.42.orig/src/testcurl/https/test_https_session_info.c
+++ libmicrohttpd-0.9.42/src/testcurl/https/test_https_session_info.c
@@ -90,6 +90,7 @@ query_session_ahc (void *cls, struct MHD
 /**
  * negotiate a secure connection with server & query negotiated security parameters
  */
+#if LIBCURL_VERSION_NUM >= 0x072200
 static int
 test_query_session ()
 {
@@ -161,7 +162,7 @@ test_query_session ()
   free (cbc.buf);
   return 0;
 }
-
+#endif
 
 int
 main (int argc, char *const *argv)
@@ -177,7 +178,9 @@ main (int argc, char *const *argv)
       fprintf (stderr, "Error (code: %u)\n", errorCount);
       return -1;
     }
+#if LIBCURL_VERSION_NUM >= 0x072200
   errorCount += test_query_session ();
+#endif
   print_test_result (errorCount, argv[0]);
   curl_global_cleanup ();
   if (errorCount > 0)

Activities

Christian Grothoff

2015-07-15 12:15

manager   ~0009449

Fixed as suggested in SVN 36085. Thanks!

Christian Grothoff

2021-09-02 15:54

manager   ~0018195

Fix committed to master branch.

Issue History

Date ModifiedUsernameFieldChange
2015-07-14 20:30matweyNew Issue
2015-07-14 20:30matweyFile Added: libmicrohttpd_test_session.patch
2015-07-15 12:15Christian GrothoffNote Added: 0009449
2015-07-15 12:15Christian GrothoffStatusnew => resolved
2015-07-15 12:15Christian GrothoffFixed in Version => 0.9.43
2015-07-15 12:15Christian GrothoffResolutionopen => fixed
2015-07-15 12:15Christian GrothoffAssigned To => Christian Grothoff
2015-07-15 12:15Christian GrothoffTarget Version => 0.9.43
2015-09-16 09:00Christian GrothoffStatusresolved => closed
2021-09-02 15:54Christian Grothoff
2021-09-02 15:54Christian GrothoffNote Added: 0018195
2024-01-21 12:25Christian GrothoffCategoryHTTPS (SSL) => HTTPS (TLS)