View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0003890 | Taler | wallet (WebExtension) | public | 2015-07-12 15:48 | 2019-12-26 20:37 |
| Reporter | Christian Grothoff | Assigned To | Marcello Stanisci | Resolution deadline | |
| Implementer | Reviewer | ||||
| Release signed by | Deployed by | ||||
| Verifier | Communicator | ||||
| Data protection authority notification required | No | ||||
| CSIRT notification required | No | ||||
| Estimated effort (hours) | Actual effort (hours) | 0 | |||
| Fast-track | No | ||||
| Work package | none | ||||
| Priority | urgent | Severity | major | Reproducibility | N/A |
| Status | closed | Resolution | fixed | ||
| Platform | i7 | OS | Debian GNU/Linux | OS Version | squeeze |
| Product Version | git (master) | ||||
| Target Version | 0.0 | ||||
| Summary | 0003890: wrap.c fails to follow coding style | ||||
| Description | The current code suffers from many issues: * lacking comments * malformed comments (non-doxygen) * misplaced comments * bad indentation * odd functions (malloc-without-initialization) * re-#defines from existing headers (instead of #including those) And the build should probably make it use libtalerutil_wallet on top of this. Please start by reading taler-mint/doc/coding-style.txt (and the documents referenced from there). Also, the various shell-scripts often also suffer from bad indentation and lack of comments. We should go over some of these issues together. | ||||
| Tags | No tags attached. | ||||
| ~80% of code has been aligned with the standard. The rest will be refactored along the implementation of 'withdraw', since there are some functions aimed for "packaging" complex signatures that have still to be tested and approved to stay in the wrapper. | |
| edit: this "0000042:00000" was a 'tilde' sign :} | |
| fixed in a5e63d7..3db1959 | |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2015-07-12 15:48 | Christian Grothoff | New Issue | |
| 2015-07-12 15:48 | Christian Grothoff | Status | new => assigned |
| 2015-07-12 15:48 | Christian Grothoff | Assigned To | => Marcello Stanisci |
| 2015-07-17 10:13 | Marcello Stanisci | Note Added: 0009456 | |
| 2015-07-17 10:13 | Marcello Stanisci | Note Added: 0009457 | |
| 2015-07-23 09:07 | Marcello Stanisci | Note Added: 0009476 | |
| 2015-07-23 09:07 | Marcello Stanisci | Status | assigned => informing |
| 2015-07-23 09:07 | Marcello Stanisci | Resolution | open => fixed |
| 2015-07-24 07:29 | Christian Grothoff | Status | informing => closed |
| 2019-12-26 20:37 | Florian Dold | Category | wallet (browser-based) => wallet (WebExtensions) |
| 2023-04-13 18:37 | Florian Dold | Category | wallet (WebExtensions) => wallet (WebExtension) |