View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0003753 | libmicrohttpd | other | public | 2015-04-10 12:27 | 2021-09-02 15:54 |
| Reporter | tomasheran | Assigned To | Christian Grothoff | Due Date | |
| Priority | normal | Severity | major | Reproducibility | always |
| Status | closed | Resolution | fixed | ||
| Product Version | Git master | ||||
| Target Version | 0.9.41 | Fixed in Version | 0.9.41 | ||
| Summary | 0003753: test_quiesce fails if there's "11" anywhere in the path leading to the tests | ||||
| Description | I believe test_quiesce.c depends on HTTP1.0 default behaviour (i.e. no keep-alive). Unfortunatelly, the test can still be "told" to ask cURL to do HTTP1.1, if "11" substring was to be found in argv[0]. Now, if any element of the path leading to the subdirectory contained that substring, test_quiesce would be run in HTTP1.1 mode and eventually fail as the existing client connection would still be used even after the main deamon was quiesced and the ServerOneRequest thread (that handled the listening socket for a few seconds) exited. | ||||
| Steps To Reproduce | Just rename the package directory to libmicrohttpd-0.9.37-11 and watch test_quiesce fail. | ||||
| Additional Information | Of course the problem is not limited to test_quiesce - *all* tests will be run in HTTP1.1 "mode", so no HTTP1.0 testing would be done whatsoever. I propose fixing test_quiesce by hardwiring HTTP1.0 in there. I propose fixing all the other tests (that can/should be legitimiately run in both HTTP1.0 and HTTP1.1 mode) by changing the argv[0] check in such a way that 11 substring will be looked for only at the end of argv[0] string. E.g. oneone = NULL != strstr (argv[0], "11") && strlen(strstr(argv[0], "11")) == 2; | ||||
| Tags | No tags attached. | ||||
| You're right, the way the testcase is written the test-logic doesn't work with pipelining and thus requires http 1.0. And yes, the 11-check should be fixed... | |
| Fixed in SVN 35537. | |
| Fix committed to master branch. | |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2015-04-10 12:27 | tomasheran | New Issue | |
| 2015-04-14 22:52 | Christian Grothoff | Note Added: 0009086 | |
| 2015-04-14 22:52 | Christian Grothoff | Status | new => confirmed |
| 2015-04-14 22:52 | Christian Grothoff | Product Version | => Git master |
| 2015-04-14 22:52 | Christian Grothoff | Target Version | => 0.9.41 |
| 2015-04-15 01:17 | Christian Grothoff | Assigned To | => Christian Grothoff |
| 2015-04-15 01:17 | Christian Grothoff | Status | confirmed => assigned |
| 2015-04-15 01:19 | Christian Grothoff | Note Added: 0009087 | |
| 2015-04-15 01:19 | Christian Grothoff | Status | assigned => resolved |
| 2015-04-15 01:19 | Christian Grothoff | Fixed in Version | => 0.9.41 |
| 2015-04-15 01:19 | Christian Grothoff | Resolution | open => fixed |
| 2015-04-29 22:13 | Christian Grothoff | Status | resolved => closed |
| 2021-09-02 15:54 | Christian Grothoff | ||
| 2021-09-02 15:54 | Christian Grothoff | Note Added: 0018198 |