View Issue Details

IDProjectCategoryView StatusLast Update
0003426GNUnetobsoletepublic2024-05-03 11:48
ReporterChristian Grothoff Assigned ToMatthias Wachs Due Date
PrioritynormalSeveritymajorReproducibilityhave not tried
Status closedResolutionfixed 
Product VersionGit master 
Target Version0.11.0pre66 
Summary0003426: ats-32362 ERROR Assertion failed at plugin_ats_proportional.c:668.
DescriptionJust got this, peer was running in the background.
TagsNo tags attached.

Relationships

has duplicate 0003442 closedMatthias Wachs Revision 33610: To have 6 active addresses looks a little bit weird. 
has duplicate 0003432 closedMatthias Wachs ats-19434 ERROR, Revision 33549 

Activities

Matthias Wachs

2014-06-10 07:32

reporter   ~0008423

Extended with additional information, now looks like:

Jun 09 09:35:38-402993 ats-proportional-12734 WARNING WAN: Counted 3 active addresses, but network says to have 15 active addresses
Jun 09 09:35:38-403352 ats-proportional-12734 WARNING Active: `T0NG' `udp' length 10
Jun 09 09:35:38-403706 ats-proportional-12734 WARNING Active: `SAJL' `udp' length 10
Jun 09 09:35:38-404058 ats-proportional-12734 WARNING Active: `PD67' `udp' length 10
Jun 09 09:35:38-654345 ats-12734 ERROR Assertion failed at plugin_ats_proportional.c:670.

Christian Grothoff

2014-06-11 10:53

manager   ~0008427

Ok, but that can clearly happen simply because there are not enough peers, right? Also, I think it is legal for there to be MORE than the number of requested connections. Assuming I'm right, I'm changing the log-level to INFO if we have _more_ than desired, and removing the "break" as this is not a logic error => SVN 33649.

Please resolve if you agree.

Matthias Wachs

2014-06-12 07:37

reporter   ~0008428

No ... there is a inconsistency in the proportional solver with counting addresses in the network:

The solver maintains a counter of active addresses and with this assertion the counter and the number of addresses counted while iterating over the list and the value of the counter are different.

At some place the number of active addresses is not correctly decreased...

Christian Grothoff

2014-06-12 15:21

manager   ~0008429

Ok, reverted SVN 33649 in SVN 33654.

Matthias Wachs

2014-06-26 14:44

reporter   ~0008470

When an outbound connection was disconnected by the destination (due to) shutdown and the session was deleted, ATS_addresses messed up the address' active setting by deactivating an address suggested as an alternative. Therefore proportional activated the address double and therefore counted it double

-> proportionals counting was messed up

Fixed with revision 33870.

Issue History

Date ModifiedUsernameFieldChange
2014-06-04 15:04Christian GrothoffNew Issue
2014-06-04 15:04Christian GrothoffStatusnew => assigned
2014-06-04 15:04Christian GrothoffAssigned To => Matthias Wachs
2014-06-08 12:11Christian GrothoffTarget Version => 0.11.0pre66
2014-06-10 07:32Matthias WachsNote Added: 0008423
2014-06-10 07:32Matthias WachsRelationship addedhas duplicate 0003442
2014-06-11 10:53Christian GrothoffNote Added: 0008427
2014-06-12 07:37Matthias WachsNote Added: 0008428
2014-06-12 15:21Christian GrothoffNote Added: 0008429
2014-06-26 14:44Matthias WachsNote Added: 0008470
2014-06-26 14:44Matthias WachsStatusassigned => resolved
2014-06-26 14:44Matthias WachsResolutionopen => fixed
2014-06-26 14:45Matthias WachsRelationship addedhas duplicate 0003432
2018-06-06 22:25Christian GrothoffStatusresolved => closed
2024-05-03 11:48Christian GrothoffCategoryATS service => obsolete