View Issue Details

IDProjectCategoryView StatusLast Update
0003047GNUnetutil librarypublic2013-12-24 19:54
ReporterChristian Grothoff Assigned ToChristian Grothoff Due Date
PriorityurgentSeveritytweakReproducibilityN/A
Status closedResolutionfixed 
Product VersionGit master 
Target Version0.10.0Fixed in Version0.10.0 
Summary0003047: struct GNUNET_PeerIdentity is larger than the public key, why not use the public key directly?
DescriptionFor historic reasons, we used to get the PID by hashing the (formerly 2048-bit) public key. With Ed25519, that bloats the key from 256 bit to 512. Thus, it would probably make sense to get rid of the hashing and use the 'struct GNUNET_PeerIdentity', as a container to box a 'struct GNUNET_CRYPTO_EccPublicKeyForSigning' (similar to how Egos box keys of users).

We'd then need another variant of the multihashmap as often peers are stored in such a hash map, and we'd then no longer have a hash available (at least not directly) for the key. But we'd reduce a frequently used HT data structure's memory consumption 50% for the key, so that's likely still a good thing to do.
TagsNo tags attached.

Activities

Christian Grothoff

2013-09-30 22:16

manager   ~0007483

The change has largely been done, except for like 100+ FTBFS issues all over the code...

Christian Grothoff

2013-10-01 22:13

manager   ~0007484

This transition should now be pretty much complete.

Issue History

Date ModifiedUsernameFieldChange
2013-09-26 19:05Christian GrothoffNew Issue
2013-09-26 19:05Christian GrothoffAssigned To => Christian Grothoff
2013-09-26 19:05Christian GrothoffStatusnew => assigned
2013-09-26 23:38Christian GrothoffPriorityimmediate => urgent
2013-09-30 22:16Christian GrothoffNote Added: 0007483
2013-10-01 22:13Christian GrothoffNote Added: 0007484
2013-10-01 22:13Christian GrothoffStatusassigned => resolved
2013-10-01 22:13Christian GrothoffFixed in Version => 0.10.0
2013-10-01 22:13Christian GrothoffResolutionopen => fixed
2013-12-24 19:54Christian GrothoffStatusresolved => closed