View Issue Details

IDProjectCategoryView StatusLast Update
0002838GNUnettransport servicepublic2013-12-24 19:55
ReporterChristian Grothoff Assigned ToMatthias Wachs Due Date
PriorityhighSeverityfeatureReproducibilityN/A
Status closedResolutionfixed 
Product VersionGit master 
Target Version0.10.0Fixed in Version0.10.0 
Summary0002838: need ability to blacklist a particular plugin for a particular connection between peers in configuration
DescriptionIn 0.8, we could say "no TCP between peer X and Y". Having this ability again,
and in particular having it in the configuration (not "just" via some API) would
be very useful, especially for DV testing as there we can then just enable
TCP+DV and blacklist some TCP connections and still expect testbed to construct a clique -- making the testcase code itself nice & trivial.
TagsNo tags attached.

Relationships

child of 0001795 closedschanzen DV is not implemented 

Activities

Christian Grothoff

2013-03-27 09:30

manager   ~0007014

read_blacklist_file () would just need to be changed to use blacklist directly from cfg section instead. -- and maybe documented better...

Matthias Wachs

2013-03-27 16:33

reporter   ~0007015

implemented in 26619.

We now support:
Adding a cfg section for a peer containing blacklisted peer + transports

Example:
On AG2P... blacklist connections to P565... on tcp:

[transport-blacklist-AG2PHES1BARB9IJCPAMJTFPVJ5V3A72S3F2A8SBUB8DAQ2V0O3V8G6G2JU56FHGFOHMQVKBSQFV98TCGTC3RJ1NINP82G0RC00N1520]
P565723JO1C2HSN6J29TAQ22MN6CI8HTMUU55T0FUQG4CMDGGEQ8UCNBKUMB94GC8R9G4FB2SF9LDOBAJ6AMINBP4JHHDD6L7VD801G = tcp

On AG2P... blacklist connections to P565... on all transports:

[transport-blacklist-AG2PHES1BARB9IJCPAMJTFPVJ5V3A72S3F2A8SBUB8DAQ2V0O3V8G6G2JU56FHGFOHMQVKBSQFV98TCGTC3RJ1NINP82G0RC00N1520]
P565723JO1C2HSN6J29TAQ22MN6CI8HTMUU55T0FUQG4CMDGGEQ8UCNBKUMB94GC8R9G4FB2SF9LDOBAJ6AMINBP4JHHDD6L7VD801G =

Christian Grothoff

2013-03-27 20:00

manager   ~0007016

The new option doesn't seem to work:

I've added the respective options to test_transport_dv_data.conf; however, despite one connection being forbidden in both directions, I still see the peers connect via TCP (gnunet-statistics, after changing if (1) to if (0) in test_transport_api_dv) and no DV seems to be used (still testbed claims to create a clique).

Matthias Wachs

2013-03-28 12:54

reporter   ~0007017

2 major fixes in blacklisting in 26633:

- connection was disallowed if any blacklist entry was existing
- plugin specific blacklist entry was added with empty string

Added 6 new testcases in transport testing in/outbound blacklisting on peer and plugin bases

-> working for me

Issue History

Date ModifiedUsernameFieldChange
2013-03-18 12:01Christian GrothoffNew Issue
2013-03-18 12:01Christian GrothoffStatusnew => assigned
2013-03-18 12:01Christian GrothoffAssigned To => Matthias Wachs
2013-03-18 12:01Christian GrothoffRelationship addedchild of 0001795
2013-03-27 09:30Christian GrothoffNote Added: 0007014
2013-03-27 16:33Matthias WachsNote Added: 0007015
2013-03-27 16:34Matthias WachsStatusassigned => resolved
2013-03-27 16:34Matthias WachsResolutionopen => fixed
2013-03-27 20:00Christian GrothoffNote Added: 0007016
2013-03-27 20:00Christian GrothoffStatusresolved => feedback
2013-03-27 20:00Christian GrothoffResolutionfixed => reopened
2013-03-27 20:01Christian GrothoffStatusfeedback => assigned
2013-03-28 12:54Matthias WachsNote Added: 0007017
2013-03-28 12:55Matthias WachsStatusassigned => resolved
2013-03-28 12:55Matthias WachsResolutionreopened => fixed
2013-04-01 16:08Christian GrothoffFixed in Version => 0.10.0
2013-04-01 16:08Christian GrothoffTarget Version => 0.10.0
2013-12-24 19:55Christian GrothoffStatusresolved => closed