View Issue Details

Jump to NotesJump to History
IDProjectCategoryView StatusDate SubmittedLast Update
0002131gnunet-gtkotherpublic2012-02-01 16:402012-02-28 10:06
ReporterChristian Grothoff Assigned ToChristian Grothoff Due Date
PrioritynormalSeveritytweakReproducibilityN/A
Status closedResolutionfixed 
Product VersionGit master 
Target Version0.9.2Fixed in Version0.9.2 
Summary0002131: signals can and should be connected using glade instead of explicit calls
DescriptionFor historical reasons, many signals are still connected manually in the C code using "g_signal_connect". Instead, the signals should be connected using glade by (1) renaming the existing handler to a GNUNET_FS_XXX_-name and making it non-static, (2) specifying the handler to be connected inside of the respective .glade-file and (3) removing the manual signal connect code from the C Code.

What needs to be checked in each case is that the 'user_ptr' / closure that is given to the signal handler's manual connect function is the same that is associated with the signal handler's by glade (2nd argument in the GNUNET_GTK_get_new_builder call). They usually match these days (and where not, we should probably investigate why not).
TagsNo tags attached.

Activities

Christian Grothoff

2012-02-03 13:00

manager   ~0005418

I think I got all of them as of SVN 19669.

Issue History

Date ModifiedUsernameFieldChange
2012-02-01 16:40Christian GrothoffNew Issue
2012-02-01 16:42Christian GrothoffStatusnew => confirmed
2012-02-03 13:00Christian GrothoffNote Added: 0005418
2012-02-03 13:00Christian GrothoffStatusconfirmed => resolved
2012-02-03 13:00Christian GrothoffFixed in Version => 0.9.2
2012-02-03 13:00Christian GrothoffResolutionopen => fixed
2012-02-03 13:00Christian GrothoffAssigned To => Christian Grothoff
2012-02-03 13:00Christian GrothoffTarget Version => 0.9.2
2012-02-28 10:06Christian GrothoffStatusresolved => closed