View Issue Details

IDProjectCategoryView StatusLast Update
0001776GNUnetDHT servicepublic2011-09-18 12:59
ReporterChristian Grothoff Assigned ToChristian Grothoff Due Date
PriorityurgentSeveritymajorReproducibilityrandom
Status closedResolutionfixed 
Summary0001776: dht multipeer test fails SOMETIMES
DescriptionAlso, the test simply fails, but doesn't give any real error message:

Sep 16 20:46:09-709463 test-dht-multipeer-30175 WARNING Found file size 3481426 for hostkeys, expect hostkeys to be size 914
Sep 16 20:46:09-709497 test-dht-multipeer-30175 WARNING Will read 3809 hostkeys from file
Sep 16 20:46:09-716015 test-dht-multipeer-30175 WARNING Read 5 total peers in topology
FAIL: test_dht_multipeer
Steps To ReproduceRun 'make check' in src/dht/ a few times (done on pixel).
Additional InformationI first thought this related to the new HAVE_UID_FOR_TESTING and/or HAVE_REPLY_BLOOMFITLER #defines, but right now it seems to happen even with the "old" code where I keep both of those fields in the messages.
TagsNo tags attached.

Relationships

related to 0001770 closedChristian Grothoff DHT includes unique id (uid) in each message, likely for no good reason 
related to 0001769 closedChristian Grothoff DHT checks peer-bloomfilter for replies 

Activities

Christian Grothoff

2011-09-16 19:30

manager   ~0004593

I've now seen the testcase pass AND fail with any combination of the defines from 0001770/0001769. It doesn't fail all the time, so maybe this just slipped through before?

Christian Grothoff

2011-09-17 20:37

manager   ~0004595

Last edited: 2011-09-17 20:37

Ok, this is related to 0001770. The unique ID is used to create the hash into the 'recent' hash map (around line 3285), which causes trouble if UIDs are always 0.

Christian Grothoff

2011-09-17 21:37

manager   ~0004597

Fixed in SVN 16920.

Issue History

Date ModifiedUsernameFieldChange
2011-09-16 18:50Christian GrothoffNew Issue
2011-09-16 18:50Christian GrothoffStatusnew => assigned
2011-09-16 18:50Christian GrothoffAssigned To => mrwiggles
2011-09-16 18:50Christian GrothoffRelationship addedrelated to 0001769
2011-09-16 18:51Christian GrothoffRelationship addedrelated to 0001770
2011-09-16 19:30Christian GrothoffNote Added: 0004593
2011-09-17 20:37Christian GrothoffNote Added: 0004595
2011-09-17 20:37Christian GrothoffNote Edited: 0004595
2011-09-17 21:37Christian GrothoffNote Added: 0004597
2011-09-17 21:37Christian GrothoffStatusassigned => resolved
2011-09-17 21:37Christian GrothoffResolutionopen => fixed
2011-09-17 21:37Christian GrothoffAssigned Tomrwiggles => Christian Grothoff
2011-09-17 21:37Christian GrothoffStatusresolved => assigned
2011-09-17 21:37Christian GrothoffStatusassigned => resolved
2011-09-18 12:59Christian GrothoffStatusresolved => closed