View Issue Details

IDProjectCategoryView StatusLast Update
0001753GNUnetutil librarypublic2011-09-15 12:19
Reporterroot Assigned ToChristian Grothoff Due Date
PrioritynormalSeverityminorReproducibilityhave not tried
Status closedResolutionfixed 
Product VersionGit master 
Summary0001753: leak in gnunet-daemon-vpn.c
Description==31546== 20 bytes in 1 blocks are definitely lost in loss record 4 of 13
==31546== at 0x4C2779D: malloc (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
==31546== by 0x5249CB2: GNUNET_xmalloc_unchecked_ (common_allocation.c:132)
==31546== by 0x5249AD4: GNUNET_xmalloc_ (common_allocation.c:61)
==31546== by 0x5249E53: GNUNET_xstrdup_ (common_allocation.c:213)
==31546== by 0x5260F81: GNUNET_GETOPT_set_string (getopt_helpers.c:228)
==31546== by 0x5260810: GNUNET_GETOPT_run (getopt.c:1033)
==31546== by 0x52664A1: GNUNET_PROGRAM_run (program.c:217)
==31546== by 0x406182: main (gnunet-daemon-vpn.c:1194)
TagsNo tags attached.

Activities

toelke

2011-09-07 11:31

reporter   ~0004564

Isn't this likely a bug in PROGRAM_run? The only code belonging to vpn is the call to PROGRAM_run:

  static const struct GNUNET_GETOPT_CommandLineOption options[] = {
    GNUNET_GETOPT_OPTION_END
  };

  return (GNUNET_OK ==
          GNUNET_PROGRAM_run (argc, argv, "vpn", gettext_noop ("help text"),
                              options, &run, NULL)) ? ret : 1;

Is there a bug in this fragment?

Christian Grothoff

2011-09-07 21:37

manager   ~0004568

No, but that fragment would not cause this leak.

I suspect it is closer to what you pass in 'options' and how you handle your globals. In any case, this one will be trivial to fix, we can look at it together on We.

Issue History

Date ModifiedUsernameFieldChange
2011-08-10 08:28rootNew Issue
2011-09-07 11:31toelkeNote Added: 0004564
2011-09-07 11:32toelkeAssigned To => Christian Grothoff
2011-09-07 11:32toelkeStatusnew => feedback
2011-09-07 21:37Christian GrothoffNote Added: 0004568
2011-09-14 07:24Christian GrothoffStatusfeedback => resolved
2011-09-14 07:24Christian GrothoffResolutionopen => fixed
2011-09-14 07:24Christian GrothoffCategoryVPN service => util library
2011-09-15 12:19Christian GrothoffStatusresolved => closed