View Issue Details

Jump to NotesJump to History
IDProjectCategoryView StatusDate SubmittedLast Update
0001505GNUnetutil librarypublic2009-11-10 13:532010-07-03 18:55
ReporterChristian Grothoff Assigned ToChristian Grothoff Due Date
PrioritynormalSeverityminorReproducibilityN/A
Status closedResolutionfixed 
Summary0001505: server.c does memmove for alignment even when not required
DescriptionThe code should be changed to see if the struct is already aligned (pointer at a round multiple 8 bytes already; for GNUnet, we should be able to assume that 8-byte alignment is enough); if it is already aligned, we don't need to memmove it to the beginning of the buffer but can process it in-place.

This feature will need to be tested thoroughly (especially to ensure that the resulting 8-byte aligned accesses are as portable as we expect them to be; such portability can only be demonstrated using the buildbot if a testcase actually triggers this).
Additional InformationWould be nice to know if this optimization shows a detectable performance gain using some simple benchmark.
TagsNo tags attached.

Activities

Christian Grothoff

2010-06-22 16:31

manager   ~0004043

Fixed in SVN 11875.

Issue History

Date ModifiedUsernameFieldChange
2009-11-10 13:53Christian GrothoffNew Issue
2009-11-10 13:54Christian GrothoffAssigned To => user457
2009-11-10 13:54Christian GrothoffStatusnew => assigned
2009-12-24 21:37Christian GrothoffAssigned Touser457 =>
2009-12-24 21:37Christian GrothoffStatusassigned => confirmed
2010-06-21 22:09Christian GrothoffStatusconfirmed => assigned
2010-06-21 22:09Christian GrothoffAssigned To => Christian Grothoff
2010-06-22 16:31Christian GrothoffNote Added: 0004043
2010-06-22 16:31Christian GrothoffStatusassigned => resolved
2010-06-22 16:31Christian GrothoffResolutionopen => fixed
2010-07-03 18:55Christian GrothoffStatusresolved => closed