View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0012186 | Taler | other | public | 2026-11-18 15:01 | 2026-11-18 16:41 |
| Reporter | bot-cg [agent] | ||||
| Priority | normal | Severity | major | Reproducibility | N/A |
| Status | new | ||||
| Product Version | git (master) | ||||
| Summary | 0012186: Unchecked array lengths and counts in exchange, merchant and anastasis: review after 2a57cbcaf [meta] | ||||
| Description | Commit 2a57cbcaf (exchange) fixed a client that trusted two arrays from the exchange to have the same length. A review of exchange, merchant, sync, challenger and anastasis for the same pattern -- a length, count or index that the code assumes matches another one but never compares -- found the defects listed as children of this issue. Each child has a patch against the current master of its repository. Reviewed at exchange 2a57cbcaf, merchant 495a791d, sync 9f3dac2, challenger 4c6140e, anastasis 83e3cb8. Challenger has none. Three sync findings of this kind are not filed here because they are already fixed on the unmerged review branch of sync (bloom-filter parameters taken from the reconcile reply, an assert on two database passes returning the same count, a partially parsed block list reported as complete). | ||||
| Tags | No tags attached. | ||||
| ID | Summary | Status | Locked by | Estimated effort (hours) |
|---|---|---|---|---|
| 0012187 | POST /reveal-melt: the number of keys in age_commitment is not checked, so a wrong count aborts taler-exchange-httpd | implementing | ||
| 0012188 | POST /kyc-upload without an ID segment crashes taler-exchange-httpd (strchr on NULL) | closed | ||
| 0012189 | POST /reveal-withdraw for a withdraw that is not age-restricted aborts taler-exchange-httpd | implementing | 2 | |
| 0012190 | RSA secmod skips a trailing empty sign request without replying, so the httpd thread waits forever for the missing signature | closed | ||
| 0012191 | libtalerexchange: /keys copied from last_keys keep auditors_size = 0, so a new auditor in the next /keys aborts the client | closed | ||
| 0012192 | libtalerexchange: since 2a57cbcaf, a coin history with a MELT entry that has no transfer_pubs is rejected as a whole | closed | ||
| 0012193 | POST /orders/$ID/pay: an over-long coins, tokens or tokens_evs array, or a null entry in tokens_evs, crashes taler-merchant-httpd during cleanup | closed | ||
| 0012194 | POST /orders/$ID/pay records surplus input tokens as spent without validating them | closed | ||
| 0012195 | TALER_MERCHANTDB_insert_transfer_details puts four stack arrays sized by the exchange's deposit count | closed | ||
| 0012196 | reducer: 'next' in AUTHENTICATIONS_EDITING crashes when no provider offers one of the authentication methods | closed | Christian Grothoff | |
| 0012207 | POST /orders/$ID/pay replay with fewer donation key pairs reads past choice->outputs | planning | Christian Grothoff | 0.5 |
| 0012208 | A non-string entry in a token family's trusted_domains/expected_domains leaves a NULL slot that aborts the merchant | closed | ||
| 0012209 | testing_api_cmd_pay_order writes past issued_tokens when a tax-receipt output comes before a token output | implementing | Christian Grothoff | 0.5 |
| 0012210 | sync client: bucket_count and k from the reconcile reply are not bounded, and the bloom filter assumes k <= bucket_count | implementing | ||
| 0012211 | sync-httpd2 reconcile asserts that two separate database passes return the same number of blocks | implementing | ||
| 0012212 | sync client: a block list that fails to parse half-way is handed out with its full length and zero-filled entries | implementing | ||
| 0012213 | Denomination helper clients do not bound failure replies by the batch, and accept a failure with TALER_EC_NONE as success | closed | ||
| 0012214 | libtalerexchange: the age_mask of a /keys denomination is not validated, and withdrawing from it aborts the client | implementing | ||
| 0012215 | taler-helper-auditor-coins sizes a stack array by the number of fresh coins of a melt read from the exchange database | closed | ||
| 0012216 | TALER_EXCHANGEDB_do_import_credits reads uninitialized duplicate flags when the procedure returns fewer rows than transfers | closed | ||
| 0012217 | POST /blinding-prepare for a CS key the helper announced but the offline tool has not signed aborts taler-exchange-httpd | closed | ||
| 0012218 | POST /aml/$OFFICER_PUB/decision sizes a stack array by the number of events in the request | closed | ||
| This issue (hours) | ||||
| Its children (hours) | 3 | |||
| Together (hours) | 3 | |||
Not planned yet: 0012207. The plan of this issue cannot be finished while part of it is unplanned.
| parent of | 0012187 | implementing | Taler | POST /reveal-melt: the number of keys in age_commitment is not checked, so a wrong count aborts taler-exchange-httpd | |
| parent of | 0012188 | closed | Taler | POST /kyc-upload without an ID segment crashes taler-exchange-httpd (strchr on NULL) | |
| parent of | 0012189 | implementing | Taler | POST /reveal-withdraw for a withdraw that is not age-restricted aborts taler-exchange-httpd | |
| parent of | 0012190 | closed | Taler | RSA secmod skips a trailing empty sign request without replying, so the httpd thread waits forever for the missing signature | |
| parent of | 0012191 | closed | Taler | libtalerexchange: /keys copied from last_keys keep auditors_size = 0, so a new auditor in the next /keys aborts the client | |
| parent of | 0012192 | closed | Taler | libtalerexchange: since 2a57cbcaf, a coin history with a MELT entry that has no transfer_pubs is rejected as a whole | |
| parent of | 0012193 | closed | Taler | POST /orders/$ID/pay: an over-long coins, tokens or tokens_evs array, or a null entry in tokens_evs, crashes taler-merchant-httpd during cleanup | |
| parent of | 0012194 | closed | Taler | POST /orders/$ID/pay records surplus input tokens as spent without validating them | |
| parent of | 0012195 | closed | Taler | TALER_MERCHANTDB_insert_transfer_details puts four stack arrays sized by the exchange's deposit count | |
| parent of | 0012196 | closed | Christian Grothoff | Anastasis | reducer: 'next' in AUTHENTICATIONS_EDITING crashes when no provider offers one of the authentication methods |
| parent of | 0012207 | planning | Christian Grothoff | Taler | POST /orders/$ID/pay replay with fewer donation key pairs reads past choice->outputs |
| parent of | 0012208 | closed | Taler | A non-string entry in a token family's trusted_domains/expected_domains leaves a NULL slot that aborts the merchant | |
| parent of | 0012209 | implementing | Christian Grothoff | Taler | testing_api_cmd_pay_order writes past issued_tokens when a tax-receipt output comes before a token output |
| parent of | 0012210 | implementing | Taler | sync client: bucket_count and k from the reconcile reply are not bounded, and the bloom filter assumes k <= bucket_count | |
| parent of | 0012211 | implementing | Taler | sync-httpd2 reconcile asserts that two separate database passes return the same number of blocks | |
| parent of | 0012212 | implementing | Taler | sync client: a block list that fails to parse half-way is handed out with its full length and zero-filled entries | |
| parent of | 0012213 | closed | Taler | Denomination helper clients do not bound failure replies by the batch, and accept a failure with TALER_EC_NONE as success | |
| parent of | 0012214 | implementing | Taler | libtalerexchange: the age_mask of a /keys denomination is not validated, and withdrawing from it aborts the client | |
| parent of | 0012215 | closed | Taler | taler-helper-auditor-coins sizes a stack array by the number of fresh coins of a melt read from the exchange database | |
| parent of | 0012216 | closed | Taler | TALER_EXCHANGEDB_do_import_credits reads uninitialized duplicate flags when the procedure returns fewer rows than transfers | |
| parent of | 0012217 | closed | Taler | POST /blinding-prepare for a CS key the helper announced but the offline tool has not signed aborts taler-exchange-httpd | |
| parent of | 0012218 | closed | Taler | POST /aml/$OFFICER_PUB/decision sizes a stack array by the number of events in the request | |
| Not all the children of this issue are yet resolved or closed. | |||||
| Added as children 12207-12218, each with a patch against current master: the findings that were left out of the first batch because the local review notes of merchant (R2-M4, H6, H2), sync (SYNC-029, SYNC-010, SYNC-056, fixed only on the unmerged dev/bots/review) and exchange (part of SECMOD-11) already had them, and the lower-severity ones (client-side age mask validation, auditor and do_import_credits row checks, the /blinding-prepare assert for unsigned CS keys, the AML decision events array). This supersedes the sentence in the description that the sync findings are not filed here. | |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2026-11-18 15:01 | bot-cg | New Issue | |
| 2026-11-18 15:01 | bot-cg | Relationship added | parent of 0012192 |
| 2026-11-18 15:01 | bot-cg | Relationship added | parent of 0012187 |
| 2026-11-18 15:01 | bot-cg | Relationship added | parent of 0012188 |
| 2026-11-18 15:01 | bot-cg | Relationship added | parent of 0012189 |
| 2026-11-18 15:01 | bot-cg | Relationship added | parent of 0012196 |
| 2026-11-18 15:01 | bot-cg | Relationship added | parent of 0012195 |
| 2026-11-18 15:01 | bot-cg | Relationship added | parent of 0012194 |
| 2026-11-18 15:01 | bot-cg | Relationship added | parent of 0012193 |
| 2026-11-18 15:01 | bot-cg | Relationship added | parent of 0012190 |
| 2026-11-18 15:01 | bot-cg | Relationship added | parent of 0012191 |
| 2026-11-18 15:01 | bot-cg | Communicator | => CM_7 |
| 2026-11-18 16:41 | bot-cg | Note Added: 0030605 |