View Issue Details

IDProjectCategoryView StatusLast Update
0012186Talerotherpublic2026-11-18 15:01
Reporterbot-cg [agent]  
PrioritynormalSeveritymajorReproducibilityN/A
Status new 
Product Versiongit (master) 
Summary0012186: Unchecked array lengths and counts in exchange, merchant and anastasis: review after 2a57cbcaf [meta]
DescriptionCommit 2a57cbcaf (exchange) fixed a client that trusted two arrays from the exchange to have the same length. A review of exchange, merchant, sync, challenger and anastasis for the same pattern -- a length, count or index that the code assumes matches another one but never compares -- found the defects listed as children of this issue. Each child has a patch against the current master of its repository.

Reviewed at exchange 2a57cbcaf, merchant 495a791d, sync 9f3dac2, challenger 4c6140e, anastasis 83e3cb8. Challenger has none. Three sync findings of this kind are not filed here because they are already fixed on the unmerged review branch of sync (bloom-filter parameters taken from the reconcile reply, an assert on two database passes returning the same count, a partially parsed block list reported as complete).
TagsNo tags attached.

Required notifications

Address or linkRemarkAdded byNotifiedActions

The plan

IDSummaryStatusLocked byEstimated effort (hours)
0012187POST /reveal-melt: the number of keys in age_commitment is not checked, so a wrong count aborts taler-exchange-httpd new
0012188POST /kyc-upload without an ID segment crashes taler-exchange-httpd (strchr on NULL) new
0012189POST /reveal-withdraw for a withdraw that is not age-restricted aborts taler-exchange-httpd new
0012190RSA secmod skips a trailing empty sign request without replying, so the httpd thread waits forever for the missing signature new
0012191libtalerexchange: /keys copied from last_keys keep auditors_size = 0, so a new auditor in the next /keys aborts the client new
0012192libtalerexchange: since 2a57cbcaf, a coin history with a MELT entry that has no transfer_pubs is rejected as a whole new
0012193POST /orders/$ID/pay: an over-long coins, tokens or tokens_evs array, or a null entry in tokens_evs, crashes taler-merchant-httpd during cleanup new
0012194POST /orders/$ID/pay records surplus input tokens as spent without validating them new
0012195TALER_MERCHANTDB_insert_transfer_details puts four stack arrays sized by the exchange's deposit count new
0012196reducer: 'next' in AUTHENTICATIONS_EDITING crashes when no provider offers one of the authentication methods new
This issue (hours)
Its children (hours)0
Together (hours)0
Not planned yet: 0012187, 0012188, 0012189, 0012190, 0012191, 0012192, 0012193, 0012194, 0012195, 0012196. The plan of this issue cannot be finished while part of it is unplanned.

Relationships

parent of 0012187 new Taler POST /reveal-melt: the number of keys in age_commitment is not checked, so a wrong count aborts taler-exchange-httpd 
parent of 0012188 new Taler POST /kyc-upload without an ID segment crashes taler-exchange-httpd (strchr on NULL) 
parent of 0012189 new Taler POST /reveal-withdraw for a withdraw that is not age-restricted aborts taler-exchange-httpd 
parent of 0012190 new Taler RSA secmod skips a trailing empty sign request without replying, so the httpd thread waits forever for the missing signature 
parent of 0012191 new Taler libtalerexchange: /keys copied from last_keys keep auditors_size = 0, so a new auditor in the next /keys aborts the client 
parent of 0012192 new Taler libtalerexchange: since 2a57cbcaf, a coin history with a MELT entry that has no transfer_pubs is rejected as a whole 
parent of 0012193 new Taler POST /orders/$ID/pay: an over-long coins, tokens or tokens_evs array, or a null entry in tokens_evs, crashes taler-merchant-httpd during cleanup 
parent of 0012194 new Taler POST /orders/$ID/pay records surplus input tokens as spent without validating them 
parent of 0012195 new Taler TALER_MERCHANTDB_insert_transfer_details puts four stack arrays sized by the exchange's deposit count 
parent of 0012196 new Anastasis reducer: 'next' in AUTHENTICATIONS_EDITING crashes when no provider offers one of the authentication methods 
Not all the children of this issue are yet resolved or closed.

Activities

There are no notes attached to this issue.

Issue History

Date ModifiedUsernameFieldChange
2026-11-18 15:01bot-cgNew Issue
2026-11-18 15:01bot-cgRelationship addedparent of 0012192
2026-11-18 15:01bot-cgRelationship addedparent of 0012187
2026-11-18 15:01bot-cgRelationship addedparent of 0012188
2026-11-18 15:01bot-cgRelationship addedparent of 0012189
2026-11-18 15:01bot-cgRelationship addedparent of 0012196
2026-11-18 15:01bot-cgRelationship addedparent of 0012195
2026-11-18 15:01bot-cgRelationship addedparent of 0012194
2026-11-18 15:01bot-cgRelationship addedparent of 0012193
2026-11-18 15:01bot-cgRelationship addedparent of 0012190
2026-11-18 15:01bot-cgRelationship addedparent of 0012191
2026-11-18 15:01bot-cgCommunicator => CM_7