| I'm not sure I understand the report. | |
| The SPA shows incoming in the first table and after the merchant checked the bank account and confirm the transfer the row moves from the first table to the second table. The second table is https://docs.taler.net/core/api-merchant.html#get-[-instances-$INSTANCE]-private-transfers Every row in the first table have the field `expected_transfer_serial_id` which can be used in https://docs.taler.net/core/api-merchant.html#get-[-instances-$INSTANCE]-private-incoming-$ID (Based on the spec) but the second table has `transfer_serial_id` In the way the spec is formulated, this section: ``` Obtain details about an expected incoming wire transfers the backend is anticipating. ID must be the expected_transfer_serial_id from ExpectedTransferDetails ``` The SPA can't use `transfer_serial_id` and there is no way to get the same information from https://docs.taler.net/core/api-merchant.html#get-[-instances-$INSTANCE]-private-incoming-$ID for wire transfer that are already confirmed. Either the spec is confusing or we need some changes to be able to show wire transfer amount calculation and aggregated orders. image.png (87,960 bytes) | |
| Ok, let me reformulate: you want to add the "expected_transfer_serial_id" to https://docs.taler.net/core/api-merchant.html#tsref-type-TransferDetails so you can link to the output of https://docs.taler.net/core/api-merchant.html#get-[-instances-$INSTANCE]-private-incoming-$ID which indeed requires an "expected_transfer_serial_id" which is indeed different from the "transfer_serial_id". Now, that value does not *always* exist -- basically only *if* {"expected":true} -- but in those cases we can and should disclose the matching "expected_transfer_serial_id". | |
| ACK that leave us with some of the confirmed transactions with expected = false unable to see the details. Is that correct? For those transactions there is no way to get this information? Sounds reasonable but I want to be sure. If that the case then we should treat this wire transfer differently. @vlada.svirsh wdyt? | |
| Well, for the unexpected transfers we cannot show details, as if we get a transaction at random (which should never happen) without justification, we cannot say what it is about. And yes, those unexpected transfers probably should be shown quite differently (different color) and would then be non-clickable. (But maybe allow easy deletion, most likely they were imported incorrectly...). | |
| API specification change pushed to taler-docs: 1dc25b94..0f799edd | |
| Implemented in 40fcdf6f..6f607ef3 | |
- Anonymous