View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0011107 | Taler | challenger | public | 2026-02-18 21:45 | 2026-09-04 19:27 |
| Reporter | vecirex | Assigned To | Christian Grothoff | Resolution deadline | |
| Implementer | Reviewer | ||||
| Release signed by | Deployed by | ||||
| Verifier | Communicator | ||||
| Data protection authority notification required | No | ||||
| CSIRT notification required | No | ||||
| Estimated effort (hours) | Actual effort (hours) | 0 | |||
| Fast-track | No | ||||
| Work package | none | ||||
| Priority | normal | Severity | minor | Reproducibility | always |
| Status | closed | Resolution | fixed | ||
| Product Version | git (master) | ||||
| Target Version | 1.6 | Fixed in Version | 1.6 | ||
| Summary | 0011107: Backend for sms auth needs fixing for cases where number wrong (e.g., too short, too long, or invalid (like flipped digit)) | ||||
| Description | Unfortunately, from our current helper scripts we get status codes like 400 or 404 for the two gateway providers we have, when we do like +41 79 NNN NN NN K, while K is too much +41 79 NNN NN N, with a missing digit somewhere (e.g., at the end) +41 79 NNN NN WN, with a W turning the number invalid (e.g., at the end) or just any other number which clearly is wrong, | ||||
| Steps To Reproduce | Doing it wrong with a pattern above, the following happens (for both SMS auth providers, telesign and clicksend): curl: (22) The requested URL returned error: 400 telesign failed. Polling message status (message_id: 1F10D12F-2AFA-6988-9122-3549D9A5CD0D)... curl: (22) The requested URL returned error: 404 clicksend failed. All SMS providers failed. taler-merchant-httpd@1b0bd36dc346:/usr/local/bin$ | ||||
| Additional Information | Of course this will also happen if it's utterly wrong, like just "+41", which currently even the backoffice SPA lets through. | ||||
| Tags | No tags attached. | ||||
| fd977f3..0e60c12 fixes this by making the helpers return more well-defined exit codes depending on the various failure scenarios and parallel commits to challenger/merchant/anastasis map those new exit codes to suitable HTTP status codes and ECs. Note that we cannot easily tell "too short" from "too long" phone numbers, as that depends on the country and would require some rather complex custom code. But, we do now properly report on 'invalid phone number' as obtained by the providers. | |
| Old / clearly solved | |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2026-02-18 21:45 | vecirex | New Issue | |
| 2026-02-18 21:47 | vecirex | Relationship added | related to 0011106 |
| 2026-02-19 01:30 | vecirex | Description Updated | |
| 2026-02-19 01:50 | vecirex | Relationship added | related to 0011108 |
| 2026-02-19 17:42 | Christian Grothoff | Relationship deleted | related to 0011108 |
| 2026-02-19 17:42 | Christian Grothoff | Relationship added | child of 0011108 |
| 2026-02-19 17:43 | Christian Grothoff | Priority | high => normal |
| 2026-02-19 17:43 | Christian Grothoff | Status | new => implementing |
| 2026-02-19 17:43 | Christian Grothoff | Target Version | => 1.8 |
| 2026-08-07 20:51 | Christian Grothoff | Assigned To | => Christian Grothoff |
| 2026-08-07 20:51 | Christian Grothoff | Status | implementing => assigned |
| 2026-08-07 20:51 | Christian Grothoff | Category | merchant backend => challenger |
| 2026-08-07 20:51 | Christian Grothoff | Product Version | => git (master) |
| 2026-08-07 20:51 | Christian Grothoff | Status | assigned => implementing |
| 2026-08-11 12:10 | Christian Grothoff | Note Added: 0029460 | |
| 2026-08-11 12:10 | Christian Grothoff | Status | implementing => informing |
| 2026-08-11 12:10 | Christian Grothoff | Resolution | open => fixed |
| 2026-08-11 12:10 | Christian Grothoff | Fixed in Version | => 1.7 |
| 2026-08-11 12:10 | Christian Grothoff | Target Version | 1.8 => 1.7 |
| 2026-08-17 16:33 | Christian Grothoff | Fixed in Version | 1.7 => 1.6 |
| 2026-08-17 16:33 | Christian Grothoff | Target Version | 1.7 => 1.6 |
| 2026-09-04 19:27 | vecirex | Note Added: 0029871 | |
| 2026-09-04 19:27 | vecirex | Status | informing => closed |