View Issue Details

IDProjectCategoryView StatusLast Update
0010765Talermerchant backendpublic2025-12-21 20:46
Reportersebasjm Assigned ToChristian Grothoff Resolution deadline
ImplementerReviewer 
Release signed byDeployed by 
VerifierCommunicator 
Data protection authority notification requiredNo  
CSIRT notification requiredNo  
Estimated effort (hours)Actual effort (hours)0 
Fast-trackNo
Work packagenone
PrioritynormalSeverityminorReproducibilityhave not tried
Status closedResolutionfixed 
Product Version1.1 
Target Version1.3Fixed in Version1.3 
Summary0010765: backend refuses to delete an instance without the owner permission
Descriptioncreate an instance with self provision
logout and login as an admin
try to delete the instance

expected: instance gets deleted
current: it ask for email/sms verification

i think this is a major problem because it would mean that the only way i can claim my disk space again is by going directly to the db
TagsNo tags attached.

Required notifications

Address or linkRemarkAdded byNotifiedActions

Activities

Christian Grothoff

2025-12-11 19:53

manager   ~0026890

Major: no. but should be fixed.

Christian Grothoff

2025-12-12 20:12

manager   ~0026943

Eh, quick question: is it asking for the admin's 2FA, or for the instance 2-FA? I think if it asked for the admin's 2-FA credentials, this might be totally OK!

sebasjm

2025-12-15 18:31

developer   ~0026994

I tested again. Starting from scratch, clean db and config

[merchant]
MANDATORY_TAN_CHANNELS = email

created the admin instrance without email
created and deleted an instance with name "qwe", didn't required email and didn't asked for MFA (which is ok)

finally I created an instance with name "asd" and email "asd@asd.com" with self provision and proceeded to delete

upon deletion the admin was asked solve MFA


$ curl 'http://merchant.taler.test/management/instances/asd?purge=NO' -X 'DELETE'
{
  "combi_and": false,
  "challenges": [
    {
      "tan_info": "asd",
      "tan_channel": "email",
      "challenge_id": "9-GYEF8A3KSQWK5PC1PKB6KYSWM1BZE92N6CHZJ2BXFDG2C0QJQ940"
    }
  ]
}

sebasjm

2025-12-15 18:34

developer   ~0026995

And the my TAN scripts logs the email that was used.

2025/12/15_15:22:56 asd@asd.com "96504243\nTaler-Merchant:\ncreate new instance"
2025/12/15_15:23:52 asd@asd.com "62580310\nTaler-Merchant:\ndelete instance"

Also the admin instance didn't have email

Christian Grothoff

2025-12-21 19:25

manager   ~0027163

c3d51301..fe526b04 changes the code to NOT require MFA if the admin is deleting the instance.
fe526b04..c5b1ec72 makes the same change if the admin is patching an instance.

Issue History

Date ModifiedUsernameFieldChange
2025-12-11 17:09sebasjmNew Issue
2025-12-11 17:09sebasjmStatusnew => assigned
2025-12-11 17:09sebasjmAssigned To => Christian Grothoff
2025-12-11 19:53Christian GrothoffNote Added: 0026890
2025-12-11 19:54Christian GrothoffSeveritymajor => minor
2025-12-11 19:54Christian GrothoffProduct Version => 1.1
2025-12-11 19:54Christian GrothoffTarget Version => 1.5
2025-12-12 20:12Christian GrothoffNote Added: 0026943
2025-12-12 20:13Christian GrothoffAssigned ToChristian Grothoff => sebasjm
2025-12-12 20:13Christian GrothoffStatusassigned => feedback
2025-12-15 18:31sebasjmNote Added: 0026994
2025-12-15 18:34sebasjmNote Added: 0026995
2025-12-15 18:34sebasjmAssigned Tosebasjm => Christian Grothoff
2025-12-15 18:34sebasjmStatusfeedback => implementing
2025-12-19 19:04Christian GrothoffStatusimplementing => assigned
2025-12-21 19:25Christian GrothoffStatusassigned => informing
2025-12-21 19:25Christian GrothoffResolutionopen => fixed
2025-12-21 19:25Christian GrothoffFixed in Version => 1.3
2025-12-21 19:25Christian GrothoffNote Added: 0027163
2025-12-21 19:26Christian GrothoffTarget Version1.5 => 1.3
2025-12-21 20:46Christian GrothoffStatusinforming => closed