View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0010757 | Taler | exchange | public | 2025-12-10 17:52 | 2025-12-21 20:46 |
| Reporter | Florian Dold | Assigned To | Florian Dold | Resolution deadline | |
| Implementer | Reviewer | ||||
| Release signed by | Deployed by | ||||
| Verifier | Communicator | ||||
| Data protection authority notification required | No | ||||
| CSIRT notification required | No | ||||
| Estimated effort (hours) | Actual effort (hours) | 0 | |||
| Fast-track | No | ||||
| Work package | none | ||||
| Priority | urgent | Severity | major | Reproducibility | have not tried |
| Status | closed | Resolution | fixed | ||
| Product Version | git (master) | ||||
| Target Version | 1.3 | Fixed in Version | 1.3 | ||
| Summary | 0010757: exchange does not return attributes set by AML officer decision (test: kyc-decision-attr) | ||||
| Description | A regression happened on the following test: $ taler-harness run-integrationtests kyc-decision-attr The exchange (ef94c79fca31b) returns an empty list of attributes after the AML officer has set an attribute via an AML decision. | ||||
| Tags | No tags attached. | ||||
| Seems that the AML decision of the test lacks the "mandatory" attribute "FORM_ID", which then causes the latest rendering logic to skip the attributes. | |
| So question: 1) is FORM_ID mandatory? If so, the test should be fixed to supply it, and the exchange to *enforce* FORM_ID to be present upon submission. 2) if not, we can return the attributes in JSON without it, but then we cannot return them in a PDF. I think (1) is the correct fix. | |
| I agree that (1) is correct. | |
| e0062e59..294a0898 clarifies that the FORM_ID is mandatory if an AML decision includes attributes. | |
| I've modifed taler-docs to specify FORM_ID as required for all attributes (on GET and POST). | |
| d34edb354..1d17a50c4 now *enforces* that the FORM_ID is always present in all attributes. | |
| kyc-decision-attr now fails (as expected) with "" FATAL: test failed with exception AssertionError [ERR_ASSERTION]: Expected values to be strictly deep-equal: 400 !== 204 "" This is because the test does NOT submit the now mandatory FORM_ID in the decision. The test should be changed to (1) expect 400 on this POST, and (2) then submit the attributes with a proper FORM_ID. | |
| kyc-fail-recover-simple fails for a related reason: FORM_ID is missing when POSTing to kyc-upload, so you're getting 400 instead of the expected 500 status now. | |
| Test passes now, as it specifies the FORM_ID in the POST decision request. | |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2025-12-10 17:52 | Florian Dold | New Issue | |
| 2025-12-10 17:52 | Florian Dold | Status | new => assigned |
| 2025-12-10 17:52 | Florian Dold | Assigned To | => Christian Grothoff |
| 2025-12-11 09:10 | Christian Grothoff | Note Added: 0026871 | |
| 2025-12-11 09:11 | Christian Grothoff | Note Added: 0026872 | |
| 2025-12-11 09:11 | Christian Grothoff | Assigned To | Christian Grothoff => Florian Dold |
| 2025-12-11 09:11 | Christian Grothoff | Status | assigned => feedback |
| 2025-12-11 15:36 | Florian Dold | Note Added: 0026879 | |
| 2025-12-11 15:37 | Florian Dold | Assigned To | Florian Dold => Christian Grothoff |
| 2025-12-14 13:30 | Christian Grothoff | Note Added: 0026965 | |
| 2025-12-14 14:03 | Christian Grothoff | Note Added: 0026966 | |
| 2025-12-14 14:10 | Christian Grothoff | Note Added: 0026967 | |
| 2025-12-14 14:12 | Christian Grothoff | Note Added: 0026968 | |
| 2025-12-14 14:12 | Christian Grothoff | Assigned To | Christian Grothoff => Florian Dold |
| 2025-12-14 14:12 | Christian Grothoff | Status | feedback => assigned |
| 2025-12-14 14:16 | Christian Grothoff | Note Added: 0026969 | |
| 2025-12-15 17:24 | Florian Dold | Status | assigned => informing |
| 2025-12-15 17:24 | Florian Dold | Resolution | open => fixed |
| 2025-12-15 17:24 | Florian Dold | Note Added: 0026993 | |
| 2025-12-15 18:16 | Christian Grothoff | Product Version | => git (master) |
| 2025-12-15 18:16 | Christian Grothoff | Fixed in Version | => 1.3 |
| 2025-12-15 18:16 | Christian Grothoff | Target Version | 1.4 => 1.3 |
| 2025-12-21 20:46 | Christian Grothoff | Status | informing => closed |