| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0010695 | Taler | merchant portal webui | public | 2025-12-01 18:29 | 2025-12-21 20:46 |
| Reporter | htgoebel | Assigned To | sebasjm | Resolution deadline | |
| Implementer | Reviewer | ||||
| Release signed by | Deployed by | ||||
| Verifier | Communicator | ||||
| Data protection authority notification required | No | ||||
| CSIRT notification required | No | ||||
| Estimated effort (hours) | Actual effort (hours) | 0 | |||
| Fast-track | No | ||||
| Work package | none | ||||
| Priority | high | Severity | major | Reproducibility | always |
| Status | closed | Resolution | fixed | ||
| Product Version | 1.0 | ||||
| Target Version | 1.3 | Fixed in Version | 1.3 | ||
| Summary | 0010695: Can create refund for wired order | ||||
| Description | Using the API one can create refunds for orders that have been wired already, see screenshot. Expected: To get Gone or another error message. | ||||
| Steps To Reproduce | - In the SPA create a payment with short deadlines and pay it. - Wait for the wire transfer deadline to be reached. - Use curl or another tools to create a refund for this order using the API. ==> This will return 200 and a MerchantRefundResponse - Go to the SPA, reload and view thise order's details ==> A "refund" will be shown | ||||
| Tags | No tags attached. | ||||
| The BIG issue here is that the merchant backend SPA fails to render the "refund_pending" field of the backend response: https://docs.taler.net/core/api-merchant.html#inspecting-orders As a result, the viewer cannot distinguish refunds that were *approved* from those that *succeeded*. We can argue that refunds after the wire deadline should not be approved anymore (easy to implement), but more importantly the SPA needs to distinguish clearly between refunds that did happen (wallet got the money) and those that were approved but the wallet did NOT get the money (for whatever reason). | |
| Merchant adjusted to 410 past wire deadline in b9c64ba7..4f8b3cf9 | |
| refund that did happen are shown as "refund taken" and refund that was approved by the merchant is shown as "refunded amount" also pending refund "pending" vs "taken" are shown green vs red In this screenshot you can see both with the fix of 0010725 where the refund URI is not there anymore after wire deadline happened. If you think that still confusing i can add a banner that says "the rest of the refund $ (refunded - taken)" image.png (27,961 bytes) image-2.png (94,967 bytes) | |
| i think the spa is clear | |
| Let's see if vlada comes up with an idea for how to make it clearer! | |
| Refund created -> Confirmed by consumer -> Refund completed / Refund failed (on hover in timeline description why failed) Can we get all these states from the backend and show in the timeline? Badges: "Refund in progress", "Refunded" if refund completed | |
| Refund created: is the red icon. I will change the text from "refund to "refund created" confirmed by the consumer: I don't this makes any sense, what are you expecting? QR code scanned but not claimed? this is much details not needed, and I think merchant doesn't bring this info. Refund completed: is the green icon. I will change the text from "refund" to "refund completed" Refund failed: the backend doesn't inform this state but we can define one here. If the refund is not completed after the wire transfer detail. I will change the text and add a (i) icon with the description of why is impossible to complete the refund. | |
| Sounds good to me. re. "confirmed by the consumer": I agree that this is not relevant for the merchant. For the merchant it is relevant whether he/she self has the coins or the customer has them. | |
| 7032a2da0..50f768fa6 | |