View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0010666 | Taler | taler-harness | public | 2025-11-26 16:19 | 2025-12-21 20:46 |
| Reporter | Florian Dold | Assigned To | Christian Grothoff | Resolution deadline | |
| Implementer | Reviewer | ||||
| Release signed by | Deployed by | ||||
| Verifier | Communicator | ||||
| Data protection authority notification required | No | ||||
| CSIRT notification required | No | ||||
| Estimated effort (hours) | Actual effort (hours) | 0 | |||
| Fast-track | No | ||||
| Work package | none | ||||
| Priority | normal | Severity | feature | Reproducibility | have not tried |
| Status | closed | Resolution | fixed | ||
| Product Version | 1.0 | ||||
| Target Version | 1.3 | Fixed in Version | 1.3 | ||
| Summary | 0010666: implement test for exchange AML officer SPA PDF generation | ||||
| Description | There is some basic support for it in the exchange, but no automated tests yet. We could simply extend the existing tests to also generate PDFs. They'll of course need to be manually checked for correctness. | ||||
| Tags | No tags attached. | ||||
| child of | 0009917 | closed | Christian Grothoff | AML SPA must be able to create PDF with entire AML file(s) [0h] |
| .. including forms created by Swissness checks. These need to be manually inspected for correctness. We also need to test the derived attributes (presence of other forms in the GwG file). | |
| The test for this is in taler-typescript-core.git/packages/taler-harness/src/integrationtests/test-tops-aml-pdf.ts line 46ff. | |
| 877933767..9b16e9592 expands the test logic, but there are many small issues I don't know how to address nicely, so leaving some for you ;-). | |
| The PDF generation currently does not work on my system at all. It seems some file is missing. Did you maybe forget to commit it? (8NKRPJ842EQPDPYDHTD8265VHR) ERROR `access' failed on file `/home/fdold-work/local/share/taler-exchange/typst-forms/_cover_.typ' at mhd_typst.c:529 with error: No such file or directory There does not seem to be a _cover.typ file in exchange.git. | |
| Eh, it is _cover_.typ, and that is in git. | |
| Hmm. Builds on my current machine now. Maybe a bootstrap issue, or maybe an issue due to the .gitignore'd Makefile.am. I've extended the test helpers with submitOfficerForm, which allows submitting forms via decisions (which is allowed in any state, not just when there is a measure for the upload). This now crashes the exchange: (HEWTDMHSPJRCKTB7JYH6TW53XR) INFO No decisions taken, creating empty cover page (HEWTDMHSPJRCKTB7JYH6TW53XR) DEBUG Running prepared statement `select_aml_attributes_dec' on 0x146be1b0 (HEWTDMHSPJRCKTB7JYH6TW53XR) DEBUG Executing prepared SQL statement `select_aml_attributes_dec' (HEWTDMHSPJRCKTB7JYH6TW53XR) DEBUG Execution of prepared SQL statement `select_aml_attributes_dec' finished (PGRES_TUPLES_OK) (HEWTDMHSPJRCKTB7JYH6TW53XR) INFO Dumping attachment `alice-id.pdf' (HEWTDMHSPJRCKTB7JYH6TW53XR) INFO Dumping attachment `alice-cr.pdf' (HEWTDMHSPJRCKTB7JYH6TW53XR) INFO Dumping attachment `charlie-id.pdf' (HEWTDMHSPJRCKTB7JYH6TW53XR) INFO Dumping attachment `charlie-mandate.pdf' (HEWTDMHSPJRCKTB7JYH6TW53XR) INFO Dumping attachment `diana-id.pdf' (HEWTDMHSPJRCKTB7JYH6TW53XR) INFO Dumping attachment `diana-resolution.pdf' (HEWTDMHSPJRCKTB7JYH6TW53XR) INFO Dumping attachment `company-id-doc.pdf' (HEWTDMHSPJRCKTB7JYH6TW53XR) ERROR Assertion failed at taler-exchange-httpd_aml-attributes-get.c:753. Aborting. | |
| I am also not sure why it logs `No decisions taken, creating empty cover page` since clearly there was a successful "POST /aml/.../decision" request. | |
| I don't get a crash, I do get a PDF... | |
| But I don't get the logs with the attachments (!?). | |
| Oh, NOW it crashes for me, too! :-) | |
| Crash fixed in fbc7b8824..320ab53cf, we still have some typst issue now. | |
| Test passes!!! | |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2025-11-26 16:19 | Florian Dold | New Issue | |
| 2025-11-26 18:05 | Christian Grothoff | Severity | minor => feature |
| 2025-11-26 18:05 | Christian Grothoff | Status | new => implementing |
| 2025-11-26 18:05 | Christian Grothoff | Target Version | => 1.4 |
| 2025-11-27 16:05 | Florian Dold | Note Added: 0026647 | |
| 2025-11-27 16:09 | Christian Grothoff | Relationship added | child of 0009917 |
| 2025-11-27 16:12 | Florian Dold | Assigned To | => Florian Dold |
| 2025-11-27 16:12 | Florian Dold | Status | implementing => assigned |
| 2025-11-28 21:14 | Florian Dold | Summary | implement test for exchange AML officer SPA PDF generation => implement test for exchange AML officer SPA PDF generation [12h] |
| 2025-11-28 22:02 | Florian Dold | Note Added: 0026678 | |
| 2025-11-28 22:02 | Florian Dold | Assigned To | Florian Dold => Christian Grothoff |
| 2025-11-28 22:02 | Florian Dold | Summary | implement test for exchange AML officer SPA PDF generation [12h] => implement test for exchange AML officer SPA PDF generation |
| 2025-12-06 16:40 | Christian Grothoff | Note Added: 0026798 | |
| 2025-12-06 16:40 | Christian Grothoff | Assigned To | Christian Grothoff => Florian Dold |
| 2025-12-10 17:54 | Florian Dold | Note Added: 0026864 | |
| 2025-12-10 17:54 | Florian Dold | Assigned To | Florian Dold => Christian Grothoff |
| 2025-12-12 19:09 | Christian Grothoff | Note Added: 0026941 | |
| 2025-12-12 19:09 | Christian Grothoff | Assigned To | Christian Grothoff => Florian Dold |
| 2025-12-12 21:21 | Florian Dold | Note Added: 0026945 | |
| 2025-12-12 21:23 | Florian Dold | Note Added: 0026946 | |
| 2025-12-12 21:23 | Florian Dold | Assigned To | Florian Dold => Christian Grothoff |
| 2025-12-14 14:34 | Christian Grothoff | Note Added: 0026971 | |
| 2025-12-14 14:35 | Christian Grothoff | Note Added: 0026972 | |
| 2025-12-15 19:44 | Christian Grothoff | Assigned To | Christian Grothoff => Florian Dold |
| 2025-12-15 19:47 | Christian Grothoff | Assigned To | Florian Dold => Christian Grothoff |
| 2025-12-15 19:47 | Christian Grothoff | Note Added: 0027002 | |
| 2025-12-15 20:15 | Christian Grothoff | Note Added: 0027003 | |
| 2025-12-15 20:47 | Christian Grothoff | Note Added: 0027004 | |
| 2025-12-16 22:00 | Christian Grothoff | Status | assigned => informing |
| 2025-12-16 22:00 | Christian Grothoff | Resolution | open => fixed |
| 2025-12-16 22:00 | Christian Grothoff | Fixed in Version | => 1.4 |
| 2025-12-21 20:45 | Christian Grothoff | Product Version | => 1.0 |
| 2025-12-21 20:45 | Christian Grothoff | Fixed in Version | 1.4 => 1.3 |
| 2025-12-21 20:45 | Christian Grothoff | Target Version | 1.4 => 1.3 |
| 2025-12-21 20:46 | Christian Grothoff | Status | informing => closed |