View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0010628 | Taler | merchant backend | public | 2025-11-18 15:57 | 2025-11-18 16:46 |
| Reporter | vecirex | Assigned To | Florian Dold | Resolution deadline | |
| Implementer | Reviewer | ||||
| Release signed by | Deployed by | ||||
| Verifier | Communicator | ||||
| Data protection authority notification required | No | ||||
| CSIRT notification required | No | ||||
| Estimated effort (hours) | Actual effort (hours) | 0 | |||
| Fast-track | No | ||||
| Work package | none | ||||
| Priority | normal | Severity | tweak | Reproducibility | always |
| Status | closed | Resolution | won't fix | ||
| Product Version | 1.0 | ||||
| Target Version | 1.2 | Fixed in Version | 1.2 | ||
| Summary | 0010628: Merchant config: options for sections ENABLED=NO vs. DISABLED=YES / ENABLED=YES vs. DISABLED=NO -- make uniform? | ||||
| Description | It looks like non-intentional, but the way only way to switch off taler-merchant's default KUDOS exchange without deleting default config incudes like kudos.conffrom /usr/share/taler-merchant/config.dor messing around with system merchant config files organizing those includes, seems to be using the option DISABLED=YES in the respective section, as I learned from @sebasjm: ty! On the other hand, the currency can be switched off by ENABLED=NO To not break existing configurations, both options could be supported, as long as the cases DISABLED=NO ENABLED=NO and DISABLED=YES ENABLED=YES in the sections yield an error, or just making that the engagement of both of those options in a given context yield an error stating one should make a decision to use just one of the two per section. | ||||
| Steps To Reproduce | An easy test is to try to useENABLED = NO to swtich off the KUDOS exchange. Working config excerpt of merchant-overrides.confused on https://taler.hacktivism.ch/ looks like this: [taler] CURRENCY = CHF ### Disable default exchange [merchant-exchange-kudos] DISABLED = YES ### Disable default currency [currency-KUDOS] ENABLED = NO [merchant] CURRENCY = CHF DATABASE = postgres [...] Changing the config to look like the following, with ENABLED = NOin the section [merchant-exchange-kudos] that is, looking uniform as in this excerpt [taler] CURRENCY = CHF ### Disable default exchange [merchant-exchange-kudos] ENABLED = NO ### Disable default currency [currency-KUDOS] ENABLED = NO [merchant] CURRENCY = CHF DATABASE = postgres [...] has no effect for the exchange and let's it appear again, as can be queried by https://taler.hacktivism.ch/config or any other site at its /config location. | ||||
| Tags | No tags attached. | ||||
| beautify: remove unnecessary whitespaces [working only partly...] | |
| fix category: exchange -> merchant backend | |
| fix typos | |
| No, making this uniform would break compatibility, allowing both enables inconsistencies, like when you set both ENABLED and DISABLED. Also, the reason for the non-uniformity is that the default is that the option is not given at all, and in some cases we then default to ENABLED while in others we default to DISABLED. Changing this now will cause major breakage, so I'm against changing it. | |
| OK, the title doesn't match description, as in the latter see: " To not break existing configurations, both options could be supported, as long as the cases [...]". In any case, a docu section on switching off default exchanges and default currencies is needed here for -- at least -- production environments, as I lost time with this, so others would most likely, too; people might also start to delete system-wide installed files, or alter other config include files including those, while none of them are meant to be changed by operators; this could then make upgrades shaky -> more support time to be used: I just opened a separate ticket (0010629), for the docu on this at least; to go here: https://docs.taler.net/taler-merchant-manual.html | |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2025-11-18 15:57 | vecirex | New Issue | |
| 2025-11-18 15:57 | vecirex | Status | new => assigned |
| 2025-11-18 15:57 | vecirex | Assigned To | => Florian Dold |
| 2025-11-18 16:00 | vecirex | Steps to Reproduce Updated | |
| 2025-11-18 16:02 | vecirex | Description Updated | |
| 2025-11-18 16:02 | vecirex | Steps to Reproduce Updated | |
| 2025-11-18 16:02 | vecirex | Note Added: 0026521 | |
| 2025-11-18 16:03 | vecirex | Note Edited: 0026521 | |
| 2025-11-18 16:04 | vecirex | Category | exchange => merchant backend |
| 2025-11-18 16:04 | vecirex | Note Added: 0026522 | |
| 2025-11-18 16:06 | vecirex | Steps to Reproduce Updated | |
| 2025-11-18 16:06 | vecirex | Note Added: 0026523 | |
| 2025-11-18 16:24 | Christian Grothoff | Note Added: 0026525 | |
| 2025-11-18 16:24 | Christian Grothoff | Status | assigned => closed |
| 2025-11-18 16:24 | Christian Grothoff | Resolution | open => won't fix |
| 2025-11-18 16:24 | Christian Grothoff | Product Version | 1.2 => 1.0 |
| 2025-11-18 16:24 | Christian Grothoff | Fixed in Version | => 1.2 |
| 2025-11-18 16:44 | vecirex | Note Added: 0026528 | |
| 2025-11-18 16:46 | vecirex | Note Edited: 0026528 |