View Issue Details

IDProjectCategoryView StatusLast Update
0010409Talerwallet-corepublic2026-09-19 14:41
ReporterFlorian Dold Assigned ToFlorian Dold Resolution deadline
ImplementerReviewer 
Release signed byDeployed by 
VerifierCommunicator 
Data protection authority notification requiredNo  
CSIRT notification requiredNo  
Estimated effort (hours)Actual effort (hours)0 
Fast-trackNo
Work packagenone
PriorityhighSeverityminorReproducibilityhave not tried
Status closedResolutionfixed 
Target Version1.6Fixed in Version1.6 
Summary0010409: diagnose / reproduce repurchase detection issue
DescriptionVia CG: "I just had a minor demo failure with repurchase detection on stage. Basically, user paid with iOS wallet against QR code on Chrome. Then I switched browser (to one with a WebExtension wallet installed), selected the same article, showed the QR code (which turned out to be HUGE), and even after the user scanned it repurchase detection didn't work: the WebExtension wallet continued to show the payment request, and not sure what the error (if any) was that the audience member was getting. But, re-loading the page also didn't work, so I'm pretty sure it wasn't PURELY a WebExtension bug. Could be wallet-core or iOS. Please do QC on repurchase detection!"
Tagsdebt

Required notifications

Address or linkRemarkAdded byNotifiedActions

Relationships

related to 0010244 closedsebasjm wallet creates extra transactions on repurchase detection [4h] 
related to 0010567 informingFlorian Dold Can't continue from claimed but unpaid order 

Activities

Florian Dold

2025-09-15 22:36

manager   ~0025920

Seems like repurchase on iOS works fine, it's just that the WebExtension (not sure yet if the UI or wallet-core) doesn't properly notice that another wallet paid for the order. Going manually to the fulfillment URL (in the browser where WebExt claimed the order) works.

Florian Dold

2025-09-15 23:03

manager   ~0025921

Looks like wallet-core doesn't handle already_paid_order_id yet.

The long-polling needs to be done with the right session_id, and when we get an already_paid_order_id, the order needs to transition into the "failed(paid-by-other)" state.

Florian Dold

2025-11-14 16:43

manager   ~0026438

Fixed here, might need some more testing:

commit 33508e19b5aef6cffb1e57307679e62f863e5b7f (HEAD -> master, origin/master, origin/HEAD)
Author: Florian Dold <florian@dold.me>
Date: Fri Nov 14 17:41:07 2025 +0100

    wallet-core: refactor checkPaymentByProposalId, improve repurchase detection

Issue History

Date ModifiedUsernameFieldChange
2025-09-15 14:17Florian DoldNew Issue
2025-09-15 14:17Florian DoldStatusnew => assigned
2025-09-15 14:17Florian DoldAssigned To => Florian Dold
2025-09-15 22:36Florian DoldNote Added: 0025920
2025-09-15 23:03Florian DoldNote Added: 0025921
2025-09-27 18:06Christian GrothoffRelationship addedrelated to 0010244
2025-09-27 18:14Christian GrothoffTarget Version1.1 => 1.3
2025-10-19 07:57Christian GrothoffTarget Version1.3 => 1.6
2025-11-14 16:43Florian DoldNote Added: 0026438
2025-11-14 19:36Florian DoldAssigned ToFlorian Dold =>
2025-11-14 19:36Florian DoldStatusassigned => feedback
2026-02-04 08:31Christian GrothoffTag Attached: debt
2026-02-04 08:31Christian GrothoffRelationship addedrelated to 0010567
2026-05-29 18:58Christian GrothoffTarget Version1.6 => 1.7
2026-08-27 09:07Florian DoldAssigned To => Florian Dold
2026-08-27 09:07Florian DoldStatusfeedback => informing
2026-08-27 09:07Florian DoldResolutionopen => fixed
2026-08-29 15:01vecirexStatusinforming => closed
2026-09-19 14:41Christian GrothoffFixed in Version => 1.6
2026-09-19 14:41Christian GrothoffTarget Version1.7 => 1.6