View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0010194 | Taler | merchant backend | public | 2025-07-16 13:46 | 2025-08-31 17:32 |
| Reporter | Florian Dold | Assigned To | Christian Grothoff | Resolution deadline | |
| Implementer | Reviewer | ||||
| Release signed by | Deployed by | ||||
| Verifier | Communicator | ||||
| Data protection authority notification required | No | ||||
| CSIRT notification required | No | ||||
| Estimated effort (hours) | Actual effort (hours) | 0 | |||
| Fast-track | No | ||||
| Work package | none | ||||
| Priority | urgent | Severity | feature | Reproducibility | have not tried |
| Status | closed | Resolution | fixed | ||
| Product Version | 1.0 | ||||
| Target Version | 1.0 stretch goals | Fixed in Version | 1.0 stretch goals | ||
| Summary | 0010194: merchant backend should improve bank account selection when creating orders | ||||
| Description | In particular, the merchant should prefer accounts that are supported by the exchanges relevant for the order. Right now, the merchant can select bank accounts where payment of the order would be impossible, since the supported exchanges do not support the wire method of the bank account. | ||||
| Tags | No tags attached. | ||||
| has duplicate | 0009748 | closed | Christian Grothoff | improve selection of bank account on order creation |
| e4f7102c..12951e28 contains a possible fix, should be checked. | |
| Note that the wallet test { "name": "kyc-fail-recover-double", "timeSec": 2.997, "status": "fail" }, fails, and we should double-check if the merchant is too permissive or if the test needs to be updated. | |
| The test now pass, it it was an unrelated issues (wrong assumptions in the test). @Christian: Can we resolve this? Or do we want/need a test in taler-harness for the new behavior of the merchant? Is it tested at all so far? | |
| I thought there was one test in the taler-harness now already. I'm OK with this being resolved for now, but also OK with more tests ;-). | |
| I've implemented a proper test, and the merchant *almost* does the right thing, but it returns the same exchange twice! You can reproduce it with: $ taler-harness run-integrationtests merchant-acctsel You'll get something like this: [...] "exchanges": [ { "master_pub": "317HC716S2M9QSMEYX21SFV3VEKCS327GXBRHZKT83Q1SSM6NNSG", "priority": 1024, "url": "http://localhost:8181/", "max_contribution": "TESTKUDOS:5" }, { "master_pub": "317HC716S2M9QSMEYX21SFV3VEKCS327GXBRHZKT83Q1SSM6NNSG", "priority": 1024, "url": "http://localhost:8181/", "max_contribution": "TESTKUDOS:5" } ], [...] FATAL: test failed with exception AssertionError [ERR_ASSERTION]: Expected values to be strictly deep-equal: 2 !== 1 | |
| Test passes with the latest merchant backend. | |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2025-07-16 13:46 | Florian Dold | New Issue | |
| 2025-07-16 15:11 | Florian Dold | Severity | minor => feature |
| 2025-07-16 18:24 | Christian Grothoff | Assigned To | => Christian Grothoff |
| 2025-07-16 18:24 | Christian Grothoff | Status | new => assigned |
| 2025-07-16 18:24 | Christian Grothoff | Product Version | => 1.0 |
| 2025-07-17 12:32 | Christian Grothoff | Priority | normal => urgent |
| 2025-07-20 14:46 | Christian Grothoff | Note Added: 0025540 | |
| 2025-07-20 14:48 | Christian Grothoff | Note Added: 0025541 | |
| 2025-07-30 09:19 | Christian Grothoff | Assigned To | Christian Grothoff => Florian Dold |
| 2025-08-20 17:22 | Florian Dold | Assigned To | Florian Dold => Christian Grothoff |
| 2025-08-20 17:22 | Florian Dold | Status | assigned => feedback |
| 2025-08-20 17:22 | Florian Dold | Note Added: 0025669 | |
| 2025-08-20 17:52 | Christian Grothoff | Note Added: 0025671 | |
| 2025-08-20 17:52 | Christian Grothoff | Assigned To | Christian Grothoff => Florian Dold |
| 2025-08-25 00:00 | Florian Dold | Note Added: 0025687 | |
| 2025-08-25 00:01 | Florian Dold | Assigned To | Florian Dold => Christian Grothoff |
| 2025-08-25 00:01 | Florian Dold | Status | feedback => assigned |
| 2025-08-28 11:47 | Christian Grothoff | Status | assigned => informing |
| 2025-08-28 11:47 | Christian Grothoff | Resolution | open => fixed |
| 2025-08-28 11:47 | Christian Grothoff | Fixed in Version | => 1.0 stretch goals |
| 2025-08-28 11:47 | Christian Grothoff | Note Added: 0025714 | |
| 2025-08-28 11:47 | Christian Grothoff | Target Version | 1.1 => 1.0 stretch goals |
| 2025-08-31 17:09 | Christian Grothoff | Status | informing => closed |
| 2025-08-31 17:32 | Christian Grothoff | Relationship added | has duplicate 0009748 |