View Issue Details

IDProjectCategoryView StatusLast Update
0010141Talerexchangepublic2025-06-30 13:43
Reporteravalos Assigned ToChristian Grothoff Resolution deadline
ImplementerReviewer 
Release signed byDeployed by 
VerifierCommunicator 
Data protection authority notification requiredNo  
CSIRT notification requiredNo  
Estimated effort (hours)Actual effort (hours)0 
Fast-trackNo
Work packagenone
PrioritynormalSeverityminorReproducibilityalways
Status closedResolutionwon't fix 
Product Version1.0 
Target Version1.0 stretch goalsFixed in Version1.0 stretch goals 
Summary0010141: old SQL files not cleared after make install
DescriptionAs you can see, some of those files are old:

$ ls -la /home/avalos/.local/share/taler-exchange/sql/
total 444
drwxr-xr-x 1 avalos avalos 490 30. Jun 14:31 .
drwxr-xr-x 1 avalos avalos 120 5. Mär 14:32 ..
-rw-r--r-- 1 avalos avalos 15311 30. Jun 14:31 auditor-triggers-0001.sql
-rw-r--r-- 1 avalos avalos 1692 30. Jun 14:31 benchmark-0001.sql
-rw-r--r-- 1 avalos avalos 1151 30. Jun 14:31 drop.sql
-rw-r--r-- 1 avalos avalos 2446 30. Jun 14:31 exchange-0001.sql
-rw-r--r-- 1 avalos avalos 187071 30. Jun 14:31 exchange-0002.sql
-rw-r--r-- 1 avalos avalos 7077 30. Jun 14:31 exchange-0003.sql
-rw-r--r-- 1 avalos avalos 767 16. Apr 13:22 exchange-0004.sql
-rw-r--r-- 1 avalos avalos 19710 16. Apr 13:22 exchange-0005.sql
-rw-r--r-- 1 avalos avalos 420 16. Apr 13:22 exchange-0006.sql
-rw-r--r-- 1 avalos avalos 3500 16. Apr 13:22 exchange-0007.sql
-rw-r--r-- 1 avalos avalos 1378 16. Apr 13:22 exchange-0008.sql
-rw-r--r-- 1 avalos avalos 33352 16. Apr 13:22 exchange-0009.sql
-rw-r--r-- 1 avalos avalos 132674 30. Jun 14:31 procedures.sql
-rw-r--r-- 1 avalos avalos 7594 30. Jun 14:31 tops-0001.sql
-rw-r--r-- 1 avalos avalos 11758 30. Jun 14:31 versioning.sql

And are causing issues when running taler-exchange-dbinit:

$ taler-exchange-dbinit -c "/tmp/taler-integrationtests-ChAWaf/wallet-tokens/exchange-testexchange-1.conf"
WARNING Could not run PSQL on file /home/avalos/.local/share/taler-exchange/sql/exchange-0005.sql: psql exit code was 3
ERROR Failed to load SQL statements from `exchange-*'
Failed to initialize database.

Running the migrations (in order) manually will reveal the following:

$ createdb taler-integrationtests
$ psql taler-integrationtests < /home/avalos/.local/share/taler-exchange/sql/versioning.sql
$ psql taler-integrationtests < /home/avalos/.local/share/taler-exchange/sql/exchange-0001.sql
$ psql taler-integrationtests < /home/avalos/.local/share/taler-exchange/sql/exchange-0002.sql
$ psql taler-integrationtests < /home/avalos/.local/share/taler-exchange/sql/exchange-0003.sql
$ psql taler-integrationtests < /home/avalos/.local/share/taler-exchange/sql/exchange-0004.sql
$ psql taler-integrationtests < /home/avalos/.local/share/taler-exchange/sql/exchange-0005.sql
BEGIN
 register_patch
----------------
(0 rows)

SET
CREATE FUNCTION
CREATE FUNCTION
CREATE FUNCTION
INSERT 0 2
ERROR: function "create_table_legitimization_measures" already exists with same argument types
TagsNo tags attached.

Required notifications

Address or linkRemarkAdded byNotifiedActions

Activities

Christian Grothoff

2025-06-30 13:43

manager   ~0025381

We can't easily clear them if you manually install. This does NOT apply to users of (binary) packages, only if you install from source without package manager. The "correct" answer is "make uninstall" on the old source tree, which of course nobody does. Manually remove them, that's the only answer we'll have. And to avoid this in the future ;-).

Issue History

Date ModifiedUsernameFieldChange
2025-06-30 13:06avalosNew Issue
2025-06-30 13:43Christian GrothoffNote Added: 0025381
2025-06-30 13:43Christian GrothoffAssigned To => Christian Grothoff
2025-06-30 13:43Christian GrothoffReproducibilityhave not tried => always
2025-06-30 13:43Christian GrothoffStatusnew => closed
2025-06-30 13:43Christian GrothoffResolutionopen => won't fix
2025-06-30 13:43Christian GrothoffProduct Version => 1.0
2025-06-30 13:43Christian GrothoffFixed in Version => 1.0 stretch goals
2025-06-30 13:43Christian GrothoffTarget Version => 1.0 stretch goals