View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0010070 | Taler | deployment and operations | public | 2025-06-04 14:26 | 2025-08-31 17:10 |
| Reporter | avalos | Assigned To | Florian Dold | Resolution deadline | |
| Implementer | Reviewer | ||||
| Release signed by | Deployed by | ||||
| Verifier | Communicator | ||||
| Data protection authority notification required | No | ||||
| CSIRT notification required | No | ||||
| Estimated effort (hours) | Actual effort (hours) | 0 | |||
| Fast-track | No | ||||
| Work package | none | ||||
| Priority | normal | Severity | minor | Reproducibility | have not tried |
| Status | closed | Resolution | fixed | ||
| Target Version | 1.0 stretch goals | Fixed in Version | 1.0 stretch goals | ||
| Summary | 0010070: TOPS exchange requires ToS download after phone number validation [5h] | ||||
| Description | For a p2p request, the KYC link first asks to validate the phone number, and then nothing happens. If you click on the link again, it then asks you to accept the ToS, and it is until then that the transaction completes. | ||||
| Tags | No tags attached. | ||||
| ID | Summary | Status | Assigned To | Estimated effort (hours) |
|---|---|---|---|---|
| 0010099 | implement DD64 (kyc check algo) in wallet-core [8h] | closed | Florian Dold | |
| This issue (hours) | ||||
| Its children (hours) | 0 | |||
| Together (hours) | 0 | |||
Nothing is missing: the plan can be finished.
| parent of | 0010099 | closed | Florian Dold | implement DD64 (kyc check algo) in wallet-core [8h] |
| It actually looks like the exchange is simply instating the zero rules here. Doesn't seem like an issue with the TOPS config, but the exchange kyclogic itself. Maybe the deposit zero rules shouldn't be applied for a wallet account (with a merge reserve payto)? Reproducer: $ taler-harness run-integrationtests tops-peer Note how the exchange logs say this after passing the challenger postal auth: 2025-06-05T02:54:03.855870+0200 taler-exchange-httpd-1598618(Y9AMDSVJ5K1XT9NAG520RJR5PC) INFO lookup_kyc_status_by_token returned 0 2025-06-05T02:54:03.855879+0200 taler-exchange-httpd-1598618(Y9AMDSVJ5K1XT9NAG520RJR5PC) INFO Making applicable zero-measures for accounts under current rules active { "measures": [ { "rule_name": "DEPOSIT-LIMIT-ZERO", .... | |
| Or ... actually, maybe the requirement is okay, and the wallet needs to do a trial merge? | |
| We can't exactly remove the zero-DEPOSIT rule here, as the wallet may still need to do a KYC-auth before DEPOSITing into a bank account, right? We validated a phone number, not a bank account. However, zero-DEPOSIT limits have nothing to do with MERGE/p2p payments, so why would the wallet care about a zero-deposit rule if we're about to do P2P payments? That makes no sense. DEPOSIT rules do *not*apply on MERGE. | |
| Indeed. Thus the wallet should improve the kyc-check handling. Here's a draft DD for the algorithm: https://docs.taler.net/design-documents/064-kyc-operation-algo.html | |
| Waiting with the implementation until the DD has been reviewed. | |
| Finished my review in 8f8839e0..d86185fd | |
| DD64 has been implemented in wallet-core v1.0.21. We also have a test to check that the wallet doesn't ask the user to do the superfluous KYC check. | |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2025-06-04 14:26 | avalos | New Issue | |
| 2025-06-04 14:51 | Christian Grothoff | Assigned To | => Florian Dold |
| 2025-06-04 14:51 | Christian Grothoff | Status | new => assigned |
| 2025-06-04 21:17 | Florian Dold | Target Version | => 1.0 stretch goals |
| 2025-06-05 00:58 | Florian Dold | Assigned To | Florian Dold => Christian Grothoff |
| 2025-06-05 01:00 | Florian Dold | Note Added: 0025139 | |
| 2025-06-05 01:17 | Florian Dold | Note Added: 0025140 | |
| 2025-06-05 07:14 | Christian Grothoff | Note Added: 0025143 | |
| 2025-06-05 07:14 | Christian Grothoff | Assigned To | Christian Grothoff => Florian Dold |
| 2025-06-05 11:43 | Florian Dold | Summary | TOPS exchange requires ToS download after phone number validation => TOPS exchange requires ToS download after phone number validation [5h] |
| 2025-06-05 11:44 | Florian Dold | Note Added: 0025147 | |
| 2025-06-05 11:56 | Florian Dold | Assigned To | Florian Dold => Christian Grothoff |
| 2025-06-05 11:56 | Florian Dold | Note Added: 0025151 | |
| 2025-06-07 11:41 | Christian Grothoff | Assigned To | Christian Grothoff => Florian Dold |
| 2025-06-07 11:42 | Christian Grothoff | Note Added: 0025180 | |
| 2025-06-12 22:44 | Florian Dold | Relationship added | parent of 0010099 |
| 2025-07-09 00:00 | Florian Dold | Note Added: 0025452 | |
| 2025-07-09 00:00 | Florian Dold | Status | assigned => informing |
| 2025-07-09 00:00 | Florian Dold | Resolution | open => fixed |
| 2025-08-31 17:09 | Christian Grothoff | Status | informing => closed |
| 2025-08-31 17:10 | Christian Grothoff | Fixed in Version | => 1.0 stretch goals |