View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0010013 | Taler | exchange | public | 2025-05-25 20:26 | 2025-08-31 17:09 |
| Reporter | Florian Dold | Assigned To | Florian Dold | Resolution deadline | |
| Implementer | Reviewer | ||||
| Release signed by | Deployed by | ||||
| Verifier | Communicator | ||||
| Data protection authority notification required | No | ||||
| CSIRT notification required | No | ||||
| Estimated effort (hours) | Actual effort (hours) | 0 | |||
| Fast-track | No | ||||
| Work package | none | ||||
| Priority | normal | Severity | minor | Reproducibility | have not tried |
| Status | closed | Resolution | fixed | ||
| Target Version | 1.0 stretch goals | Fixed in Version | 1.0 stretch goals | ||
| Summary | 0010013: AML programs do not receive input new_rules.custom_measures despite it being mandatory in the spec | ||||
| Description | That means that rules don't round-trip nicely, making it more difficult than necessary to keep the current rules. | ||||
| Tags | No tags attached. | ||||
| That's strange, we don't really touch the new_rules before passing them through. Do you have a test? | |
| It really cannot be: there is no code (!) in the exchange to convert a LegitimizationRuleSet (LRS) to JSON, only to parse the JSON and then to (re)build sub-parts (for wallets/clients) of that JSON. Which means we receive the JSON LRS, store it in JSON in the DB, and always -- if we return any LRS -- return exactly what we received previously. So I suspect you have some helper that threw away the custom_measures (happened to me before...), but it won't be the exchange! | |
| The following test triggers a 500 response on form upload from the exchange, using *only* the helper taler-exchange-helper-measure-inform-investigate shipped with the exchange. $ taler-harness run-integrationtests kyc-merchant-deposit-form So either this helper is broken or the exchange isn't passing the LRS correctly. Or maybe not constructing the initial LRS correctly from default rules. | |
| commit f6026688d2c2d42f0c32ba59582213f70a276e2e (HEAD -> master, origin/master, origin/HEAD) Author: Florian Dold <florian@dold.me> Date: Mon May 26 14:36:14 2025 +0200 ensure that default LRS specifies custom_measures It is a mandatory field. Issue: https://bugs.taler.net/n/10013 | |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2025-05-25 20:26 | Florian Dold | New Issue | |
| 2025-05-25 20:26 | Florian Dold | Status | new => assigned |
| 2025-05-25 20:26 | Florian Dold | Assigned To | => Christian Grothoff |
| 2025-05-25 22:34 | Christian Grothoff | Note Added: 0024992 | |
| 2025-05-26 06:39 | Christian Grothoff | Note Added: 0024998 | |
| 2025-05-26 06:39 | Christian Grothoff | Assigned To | Christian Grothoff => Florian Dold |
| 2025-05-26 06:39 | Christian Grothoff | Status | assigned => feedback |
| 2025-05-26 07:58 | Florian Dold | Note Added: 0024999 | |
| 2025-05-26 07:58 | Florian Dold | Assigned To | Florian Dold => Christian Grothoff |
| 2025-05-26 07:58 | Florian Dold | Status | feedback => assigned |
| 2025-05-26 11:03 | Florian Dold | Assigned To | Christian Grothoff => Florian Dold |
| 2025-05-26 12:42 | Florian Dold | Status | assigned => informing |
| 2025-05-26 12:42 | Florian Dold | Resolution | open => fixed |
| 2025-05-26 12:42 | Florian Dold | Note Added: 0025009 | |
| 2025-06-03 17:52 | Christian Grothoff | Fixed in Version | => 1.0 stretch goals |
| 2025-08-31 17:09 | Christian Grothoff | Status | informing => closed |