View Issue Details

IDProjectCategoryView StatusLast Update
0009752Talerchallengerpublic2025-05-10 02:11
Reportersebasjm Assigned ToChristian Grothoff Resolution deadline
ImplementerReviewer 
Release signed byDeployed by 
VerifierCommunicator 
Data protection authority notification requiredNo  
CSIRT notification requiredNo  
Estimated effort (hours)Actual effort (hours)0 
Fast-trackNo
Work packagenone
PriorityhighSeveritymajorReproducibilityalways
Status closedResolutionfixed 
Target Version1.0Fixed in Version1.0 
Summary0009752: can't trigger the challenge when read only
Descriptionthis is because challenger-httpd_challenge.c line 536 the check_restrictions is waiting for all the fields to be string and read_only is not.

adding

    if ((0 == strcmp (key,
                    "read_only")) &&
        (json_boolean_value(val)) )
      continue;

to skip the check for read only works but then it fails after

Apr 17 12:58:48 challenger-httpd[124249]: (NA53RDQA66S94Z81EGQGPN77SG) DEBUG Executing prepared SQL statement `do_challenge_set_address_and_pin'
Apr 17 12:58:48 challenger-httpd[124249]: (NA53RDQA66S94Z81EGQGPN77SG) DEBUG Execution of prepared SQL statement `do_challenge_set_address_and_pin' finished (PGRES_TUPLES_OK)
Apr 17 12:58:48 challenger-httpd[124249]: (NA53RDQA66S94Z81EGQGPN77SG) ERROR NULL field encountered for `last_pin' where non-NULL was required
Apr 17 12:58:48 challenger-httpd[124249]: (NA53RDQA66S94Z81EGQGPN77SG) ERROR Assertion failed at challenger-httpd_challenge.c:816.



$ curl -X POST "http://challenger.taler.test:1180/challenge/0ATJCEGKXKWAXGADGAC47TSPAQCABPA442Y254WRYZ1AFSNWV6H0" -H "Content-Type: application/json" -H "Accept: application/json" -d '{"email":"AXFSJJQ5Q0EPX0T4Q03CDFEN8M6CX354R4ZEZ2VM0C7WX4VGTEQG@email.com","read_only":true}' -v
Note: Unnecessary use of -X or --request, POST is already inferred.
* Host challenger.taler.test:1180 was resolved.
* IPv6: (none)
* IPv4: 127.0.0.1
* Trying 127.0.0.1:1180...
* Connected to challenger.taler.test (127.0.0.1) port 1180
> POST /challenge/0ATJCEGKXKWAXGADGAC47TSPAQCABPA442Y254WRYZ1AFSNWV6H0 HTTP/1.1
> Host: challenger.taler.test:1180
> User-Agent: curl/8.5.0
> Content-Type: application/json
> Accept: application/json
> Content-Length: 92
>
< HTTP/1.1 400 Bad Request
< Server: nginx/1.24.0 (Ubuntu)
< Date: Thu, 17 Apr 2025 15:56:00 GMT
< Content-Type: application/json
< Content-Length: 241
< Connection: keep-alive
< Access-Control-Allow-Origin: *
< Access-Control-Expose-Headers: *
< Access-Control-Allow-Credentials: true
<
{
  "code": 26,
  "hint": "A parameter in the request was malformed. This is likely a bug in the client implementation. Check if you are using the latest available version and/or file a report with the developers.",
  "detail": "read_only"
* Connection #0 to host challenger.taler.test left intact
}
TagsNo tags attached.

Required notifications

Address or linkRemarkAdded byNotifiedActions

Activities

There are no notes attached to this issue.

Issue History

Date ModifiedUsernameFieldChange
2025-04-17 16:04sebasjmNew Issue
2025-04-17 16:04sebasjmStatusnew => assigned
2025-04-17 16:04sebasjmAssigned To => Christian Grothoff
2025-04-17 18:52Christian GrothoffStatusassigned => informing
2025-04-17 18:52Christian GrothoffResolutionopen => fixed
2025-04-17 18:52Christian GrothoffFixed in Version => 1.0
2025-05-10 02:11Christian GrothoffStatusinforming => closed