View Issue Details

IDProjectCategoryView StatusLast Update
0006953Talermerchant backendpublic2024-01-12 13:04
Reportersebasjm Assigned ToChristian Grothoff Resolution deadline
ImplementerReviewer 
Release signed byDeployed by 
VerifierCommunicator 
Data protection authority notification requiredNo  
CSIRT notification requiredNo  
Estimated effort (hours)Actual effort (hours)0 
Fast-trackNo
Work packagenone
PrioritynormalSeverityminorReproducibilityalways
Status closedResolutionfixed 
Product Versiongit (master) 
Target Version0.8Fixed in Version0.8 
Summary0006953: Add verifier for order.products content in order creation
Descriptionfile: taler-merchant-httpd_private-post-orders
function: merge_inventory
line: 1194

function is checking that order.products is an array but deeper checks are needed.

Order follow this spec https://docs.taler.net/core/api-merchant.html#tsref-type-ContractTerms
Product json must match this spec https://docs.taler.net/core/api-merchant.html#tsref-type-Product

in function execute_order at line 392
check_products is called but is not complete
if there is an invalid order the check will not able to distinguish if the order came from the database or from the request.
TagsNo tags attached.

Required notifications

Address or linkRemarkAdded byNotifiedActions

Activities

There are no notes attached to this issue.

Issue History

Date ModifiedUsernameFieldChange
2021-07-23 11:43sebasjmNew Issue
2021-07-23 11:43sebasjmStatusnew => assigned
2021-07-23 11:43sebasjmAssigned To => sebasjm
2021-08-01 13:12Christian GrothoffAssigned Tosebasjm => Christian Grothoff
2021-08-01 13:12Christian GrothoffTarget Versiongit (master) => 0.8
2021-08-04 17:25Christian GrothoffStatusassigned => informing
2021-08-04 17:25Christian GrothoffResolutionopen => fixed
2021-08-04 17:25Christian GrothoffFixed in Version => 0.8
2021-08-24 14:22Christian GrothoffStatusinforming => closed
2024-01-12 13:04Christian GrothoffCategorymerchant backend API (C) => mechant backend
2025-03-22 13:09Christian GrothoffCategorymechant backend => merchant backend