View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0006784 | Taler | obsolete component | public | 2021-03-04 06:25 | 2022-11-04 19:53 |
| Reporter | sebasjm | Assigned To | MS | Resolution deadline | |
| Implementer | Reviewer | ||||
| Release signed by | Deployed by | ||||
| Verifier | Communicator | ||||
| Data protection authority notification required | No | ||||
| CSIRT notification required | No | ||||
| Estimated effort (hours) | Actual effort (hours) | 0 | |||
| Fast-track | No | ||||
| Work package | none | ||||
| Priority | normal | Severity | major | Reproducibility | always |
| Status | closed | Resolution | won't fix | ||
| Product Version | git (master) | ||||
| Target Version | 0.9 | ||||
| Summary | 0006784: error parsing while doing a wire transfer | ||||
| Description | Wire transfer cannot be done. I think is for this change https://git.taler.net/bank.git/commit/?id=354f6f6608eb14e8fd27669f08d8eabacd35098f PaytoParse is being use here: https://git.taler.net/bank.git/tree/talerbank/app/views.py#n354 And parameters being taken from here: https://git.taler.net/bank.git/tree/talerbank/app/templates/payto_wiretransfer.html#n41 I have pushed a fix but it will be nice to have a review (8663a5a) | ||||
| Steps To Reproduce | go to bank create an account wire transfer to exchange produce error PaytoParse doesnt have a account field | ||||
| Additional Information | diff --git a/talerbank/app/templates/payto_wiretransfer.html b/talerbank/app/templates/payto_wiretransfer.html index 91737e2..cdb3c0e 100644 --- a/talerbank/app/templates/payto_wiretransfer.html +++ b/talerbank/app/templates/payto_wiretransfer.html @@ -31,7 +31,7 @@ {{ _("Transfer money via the payto system:") }} <form action="{{ url('payto-transfer') }}" method="POST" @@ -39,7 +39,7 @@ <input type="hidden" name="csrfmiddlewaretoken" value="{{ csrf_token }}" /> <input name="address" placeholder={{ _("payto address") }} - pattern="payto://x-taler-bank/[a-z\.]+(:[0-9]+)?/[0-9]+\?subject=[a-zA-Z0-9]+&amount={{ currency }}:[0-9]+(\.[0-9]+)?" /> + pattern="payto://x-taler-bank/[a-z\.]+(:[0-9]+)?/[0-9]+\?message=[a-zA-Z0-9]+&amount={{ currency }}:[0-9]+(\.[0-9]+)?" /> <input class="pure-button pure-button-primary" type="submit" value={{ _("Confirm") }} /> diff --git a/talerbank/app/views.py b/talerbank/app/views.py index 90c34b6..318016e 100644 --- a/talerbank/app/views.py +++ b/talerbank/app/views.py @@ -352,8 +352,8 @@ def payto_transfer(request): wire_transfer( parsed_address.amount, BankAccount.objects.get(user=request.user), - BankAccount.objects.get(account_no=parsed_address.account), - parsed_address.subject, + BankAccount.objects.get(account_no=parsed_address.target), + parsed_address.message, ) set_session_hint(request, success=True, hint=gettext("Wire transfer successful!")) return redirect("profile") | ||||
| Tags | No tags attached. | ||||
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2021-03-04 06:25 | sebasjm | New Issue | |
| 2021-03-04 06:25 | sebasjm | Status | new => assigned |
| 2021-03-04 06:25 | sebasjm | Assigned To | => MS |
| 2021-08-24 18:53 | Christian Grothoff | Target Version | => 0.9 |
| 2021-11-25 20:47 | sebasjm | Status | assigned => informing |
| 2021-11-25 20:47 | sebasjm | Resolution | open => won't fix |
| 2022-08-23 18:26 | Christian Grothoff | Category | bank (demonstrator) => py bank (demonstrator, obsolete) |
| 2022-11-04 19:53 | Christian Grothoff | Status | informing => closed |
| 2023-12-03 00:23 | Christian Grothoff | Category | py bank (demonstrator, obsolete) => obsolete componet |
| 2023-12-11 19:08 | Florian Dold | Category | obsolete componet => obsolete component |